Add ops file to enable CF api v2 #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable-v2-api.yml can be used by operators to re-enable v2 once it gets disabled by default (~Q1 25) - there is an experimental ops file disable-v2-api.yml which will be deprecated and removed later
jochenehret
previously approved these changes
Dec 4, 2024
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
jochenehret
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this change about?
Add an ops file to enable CF api v2.
enable-v2-api.ymlcan be used by operators to re-enable v2 once it gets disabled by default (~Q1 25).What customer problem is being addressed?
https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0032-cfapiv2-eol.md
We are currently in Phase 1 of the described removal process and the next step is to turn off CF API v2 by default in cf-deployment. The proposed ops file
enable-v2-api.ymlcan be used by operators to re-enable v2.Please provide any contextual information.
https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0032-cfapiv2-eol.md
cloudfoundry/community#1001
Today (cf-d 45.x), CF API v2 is enabled by default and operators can use the experimental ops file
disable-v2-api.ymlto disable v2.In a future cf-d version, we plan to disable CF API v2 by default and operators use the proposed ops file
enable-v2-api.ymlto enable v2 again.Has a cf-deployment including this change passed cf-acceptance-tests?
Today, the new ops file is a no-op because the CAPI property cc.temporary_enable_v2 is still set to true by default.
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
How should this change be described in cf-deployment release notes?
No need to mention it now in the release notes. It will be mentioned in a future major cf-deployment version when CAPI disables CF API v2 by default. Planned for beginning 2025.
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
It sets the bosh config property cc.temporary_enable_v2 of capi-release to its default value = no-op
Please provide Acceptance Criteria for this change?
If the new ops file is added to cf-deployment 45.x, the generated bosh manifest doesn't change.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@jochenehret