This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we increment the IP ranges from
.7
,.8
,.9
to.16
,.17
,.18
, it will play nicer with other canonical bosh-deployment and cf-deployment repositories.This is because the cf-deployment sets up a cloud-config range of
10.244.0.0/20
. That only has a usable range to.15
:And the convention in bosh-lite has been to add a route for internal containers to be on a
10.244.0.0/16
range. So we can get to more networks than just the cf-deployment's/20
.I've tested the
.16
,.17
,.18
, and all three deployments (bosh-deployment, cf-deployment, cf-mysql-deployment) work better "out of the box" with these changes.