Remove json pure #99
Remove json pure #99
Conversation
Co-authored-by: Brian Upton <[email protected]>
Per the following warning printed when running specs: > `json_pure` is deprecated and has no effect, just use `json` Co-authored-by: Brian Upton <[email protected]>
|
PS. Ruby |
| @@ -31,8 +31,7 @@ Gem::Specification.new do |s| | |||
| s.require_paths = ['lib'] | |||
|
|
|||
| # dependencies | |||
| s.add_dependency 'multi_json', '>= 1.12.1', '< 1.16' | |||
There was a problem hiding this comment.
why remove multi_json as well? I was looking at the commit history and saw that it was explicitly added again here: dbc4249
There was a problem hiding this comment.
I suspect this may be some sort of compatibility thing with json / json_pure though I'm not sure....
per the multi-json readme it looks like in order to use it one should require multi_json and use it via MultiJson...
Doing a search in cf-uaa-lib I don't see any uses of MultiJson:
https://github.com/search?q=repo%3Acloudfoundry%2Fcf-uaa-lib%20MultiJson&type=code
... and the only results for multi_json are in the LICENSE file.
|
@coolgang123 - is there an ETA on when a gem version with this change will be released? |
Per the following warning printed when running specs:
In addition we are seeing errors in BOSH related to
json_pureand rather than dive in to fixing this we would prefer to remove the problem at the source.