fix compilation on ubuntu-noble #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as a draft PR pending some validation of this work on an internal pipeline. |
- vendor pkg-config; This seems to be required for MySQL to correctly detect OpenSSL on ubuntu-noble now. This adds a new bosh blob, pkg-config v0.29.2 - vendor libaio; libaio version was bumped and the old packaging method of compiling against a "stub" libaio but used the copy on the stemcell no longer works. Fixes #54
e2e-tests use the default manifests at the top-level of the repo and their default stemcell. Add a new STEMCELL_OS parameter that, if set, will override the stemcell os name to test against an alternate stemcell. This allows testing against both jammy and noble by changing a test parameter.
abg
force-pushed
the
feature/support-ubuntu-noble-stemcells
branch
2 times, most recently
from
32b77d8 to
52e9938
Compare
This may be short lived, but fixes intended use of the bootstrap errand which coordinates with this agent to start MySQL instances in the correct order after a cluster has gone offline.
abg
force-pushed
the
feature/support-ubuntu-noble-stemcells
branch
from
52e9938 to
ba02c08
Compare
|
Reviewed with @ryanwittrup earlier this week, made a few small adjustments and have seen e2e-tests go green. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two primary changes:
vendor pkg-config; This seems to be required for MySQL to correctly detect OpenSSL on ubuntu-noble now.
This adds a new bosh blob, pkg-config v0.29.2
vendor libaio; libaio version was bumped and the old packaging method of compiling against a "stub" libaio but used the copy on the stemcell no longer works.
Fixes #54
Thanks for opening a PR. Please make sure you've read and followed the Contributing guide, including signing the Contributor License Agreement.
Feature or Bug Description
What does this PR change?
This PR introduces changes to packaging scripts for MySQL components to compile under the ubuntu-noble stemcell.
Additionally introduces a new build dependency: pkg-config.
Motivation
Tell us about the problem you are facing, with context, that this PR solves.
Solving the compilation issues noted in #54.
Related Issue
If this PR was first opened as an issue, please provide the link to that issue here.
See #54