Automatically rebuild DirectAdmin during elevation #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os-directadmin-elevation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
prilr
pushed a commit
that referenced
this pull request
Aug 30, 2024
Previous efibootorderfix versions were incorrectly specifying the partition number being passed to `efibootmgr`. This change makes that more dynamic. Also, in cases where `/boot/efi` is an actual md mirror, this PR adds the logic to add EFI boot targets for each of the mirror plexes, instead of just a single plex of the mirror, so better repliates EFI boot targets as set up by OS distro installs which automatically make use of multiple plexes. Example output after a successful upgrade - note the duplicate (mirrored) boot entries for "Rocky Linux": ``` BootCurrent: 0005 Timeout: 3 seconds BootOrder: 0005,0004,0002,0003 Boot0002* UEFI: Built-in EFI Shell VenMedia(5023b95c-db26-429b-a648-bd47664c8012)..BO Boot0003* UEFI: PXE IP4 Cisco 1GigE I350 LOM PciRoot(0x0)/Pci(0x1c,0x0)/Pci(0x0,0x0)/MAC(d4789b4a161c,1)/IPv4(0.0.0.00.0.0.0,0,0)..BO Boot0004* Rocky Linux HD(3,GPT,3566f194-fa71-4539-9687-2b20f67841ed,0xa00800,0x80000)/File(\EFI\rocky\shimx64.efi) Boot0005* Rocky Linux HD(3,GPT,ad6e8abc-5728-4435-9b84-1c28cb5a18cf,0xa00800,0x80000)/File(\EFI\rocky\shimx64.efi) ``` (cherry picked from commit d7e5f72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic DirectAdmin build execution on first boot after elevation.