Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): quote dnsNames starting with asterisk #641

Merged
merged 3 commits into from
Feb 13, 2025
+9 −5
Merged

fix(alerts): quote dnsNames starting with asterisk #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d85b1d7
fix(alerts): quote dnsNames starting with asterisk
richardtief Feb 13, 2025
9d9619c
chore(alerts): add baseDomain to ci test values
richardtief Feb 13, 2025
30f8940
chore(alerts): fix ci test value baseDomain
richardtief Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion alerts/charts/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ maintainers:
name: alerts
sources:
- https://github.com/cloudoperators/greenhouse-extensions
version: 0.19.0
version: 0.19.1
keywords:
- prometheus-alertmanager
dependencies:
Expand Down
4 changes: 4 additions & 0 deletions alerts/charts/ci/test-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company and Greenhouse contributors
# SPDX-License-Identifier: Apache-2.0
global:
greenhouse:
baseDomain: example.com

alerts:
alertmanager:
ingress:
Expand Down
2 changes: 1 addition & 1 deletion alerts/charts/templates/certmanager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,6 @@ spec:
{{- end }}
dnsNames:
{{- if .Values.global.greenhouse.baseDomain }}
- {{ printf "*.s%" .Values.global.greenhouse.baseDomain }}
- {{ printf "*.%s" .Values.global.greenhouse.baseDomain | quote }}
{{- end }}
{{- end -}}
2 changes: 1 addition & 1 deletion alerts/charts/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ alerts:
duration: "" # default to be 5y
admissionCert:
duration: "" # default to be 1y
issuerRef:
issuerRef: {}
# name: "issuer"
# kind: "ClusterIssuer"

Expand Down
4 changes: 2 additions & 2 deletions alerts/plugindefinition.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ kind: PluginDefinition
metadata:
name: alerts
spec:
version: 2.7.0
version: 2.7.1
weight: 0
displayName: Alerts
description: The Alerts Plugin consists of both Prometheus Alertmanager and Supernova, the holistic alert management UI
Expand All @@ -15,7 +15,7 @@ spec:
helmChart:
name: alerts
repository: oci://ghcr.io/cloudoperators/greenhouse-extensions/charts
version: 0.19.0
version: 0.19.1
uiApplication:
name: supernova
version: "latest"
Expand Down
Loading