-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support application-controlled session stickiness #95
Open
abeluck
wants to merge
1
commit into
cloudposse:main
Choose a base branch
from
abeluck:feat/application-cookies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
previously approved these changes
Dec 10, 2024
/terratest |
Sorry @nitrocode I'm having trouble parsing all that test output. Is the failing test related at all to my change? |
💥 This pull request now has conflicts. Could you fix it @abeluck? 🙏 |
auto-merge was automatically disabled
December 16, 2024 11:18
Head branch was pushed to by a user without write access
abeluck
force-pushed
the
feat/application-cookies
branch
from
December 16, 2024 11:18
2162c1c
to
f47a41b
Compare
@nitrocode I resolved the merge conflict |
mergify
bot
added
triage
Needs triage
and removed
conflict
This PR has conflicts
labels
Dec 16, 2024
nitrocode
approved these changes
Jan 5, 2025
/terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
this is a recreation of #60 without merge conflicts.
why
see #60 which this PR supersedes
references