Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add load_balancing_anomaly_mitigation #96

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

mschfh
Copy link
Contributor

@mschfh mschfh commented Dec 11, 2024

variables.tf Outdated Show resolved Hide resolved
@mschfh mschfh force-pushed the lb-anomaly-mitigation branch from c09b75a to 7ce71fd Compare December 11, 2024 14:58
@mschfh mschfh requested a review from nitrocode December 11, 2024 15:03
@gberenice
Copy link
Contributor

/terratest

@gberenice
Copy link
Contributor

@mschfh I know it's not related to your contribution, but to pass the tests, we must update the AWS account value, as it's done here https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/pull/252/files
Could you please do that so I can approve your work? Much appreciate you!

@mschfh
Copy link
Contributor Author

mschfh commented Dec 11, 2024

@gberenice done.

Thanks for the quick review!

@gberenice
Copy link
Contributor

/terratest

@gberenice gberenice merged commit a43c2d5 into cloudposse:main Dec 11, 2024
16 checks passed
@mergify mergify bot removed the triage Needs triage label Dec 11, 2024
Copy link
Contributor

These changes were released in v0.29.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants