feat(aws_instance): add ignore_ami_changes option #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
reviewed
Sep 6, 2024
| @@ -171,6 +171,10 @@ resource "aws_instance" "default" { | |||
| tags = module.this.tags | |||
|
|
|||
| volume_tags = var.volume_tags_enabled ? module.this.tags : {} | |||
|
|
|||
| lifecycle { | |||
| ignore_changes = var.ignore_ami_changes ? [ami] : [] | |||
There was a problem hiding this comment.
I don't believe variables are supported in lifecycle blocks in terraform
There was a problem hiding this comment.
You're right. Well, that's what I get by not testing things properly
|
Thanks for the pr @Lawstorant. Instead of updating the module, have you considered simply setting the Also have you folks considered using an autoscaling group of 1 instance to have more control over the EC2s ? It might be better for your purposes. |
|
My problem is that I'm setting the ami input already, but the input data comes from a filter in a data source. Well, I'm going to filter it better and close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Allow ignoring AMI image ID changes. EC2 instance won't be recreated If the AMI image id is provided from a data source changes.
why
We use an aws_ami data Blocks that always provides the most recent version of selected image but that will cause the EC2 to recreate if the image is updated. We want to be able to upgrade only when we see fit.