-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for zonal shift configuration #243
Conversation
/terratest |
Thanks, I'll check test failures. |
@z0rc, thanks for your contribution!
could you please update zonal_shift_config to use a block? see |
@gberenice I decided to use dynamic block here, as it optional in provider and most configurations won't have it set. |
/terratest |
Okay, almost there. Need a bit more time. |
@gberenice ready to test. |
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @z0rc!
These changes were released in v4.4.1. |
what
Add support of zonal shift config for the cluster. Closes #242
why
See linked ticket.
references
See linked ticket.
additional info
<br>
to<br/>
changes are caused by new version ofterraform-docs
and are intended, see terraform-docs/terraform-docs#787