fix: prevent creating empty replicas record #126
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -134,7 +134,7 @@ resource "aws_rds_cluster" "primary" { | |||||||||||||||||||
|
|
||||||||||||||||||||
| # https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster#replication_source_identifier | ||||||||||||||||||||
| resource "aws_rds_cluster" "secondary" { | ||||||||||||||||||||
| count = local.enabled && !local.is_regional_cluster ? 1 : 0 | ||||||||||||||||||||
|
There was a problem hiding this comment.
|
||||||||||||||||||||
| Path | Resource | Connecting Attribute |
|---|---|---|
| /main.tf | aws_rds_cluster_instance.default | depends_on |
| cluster | coalesce(join(, aws_rds_cluster.primary.*.id), join(, aws_rds_cluster.secondary.*.id)) | resource_id |
There was a problem hiding this comment.
Ensure RDS clusters have an AWS Backup backup plan
Resource: aws_rds_cluster.secondary | ID: BC_AWS_GENERAL_49
How to Fix
resource "aws_rds_cluster" "rds_cluster_good" {
cluster_identifier = "aurora-cluster-demo"
engine = "aurora-mysql"
engine_version = "5.7.mysql_aurora.2.03.2"
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
database_name = "mydb"
master_username = "foo"
master_password = "bar"
}
resource "aws_backup_plan" "example" {
name = "tf_example_backup_plan"
rule {
rule_name = "tf_example_backup_rule"
target_vault_name = "vault-name"
schedule = "cron(0 12 * * ? *)"
}
}
resource "aws_backup_selection" "backup_good" {
iam_role_arn = "arn:partition:service:region:account-id:resource-id"
name = "tf_example_backup_selection"
plan_id = aws_backup_plan.example.id
resources = [
aws_rds_cluster.rds_cluster_good.arn
]
}
Description
TBADependent Resources
| Path | Resource | Connecting Attribute |
|---|---|---|
| /main.tf | aws_rds_cluster_instance.default | depends_on |
| cluster | coalesce(join(, aws_rds_cluster.primary.*.id), join(, aws_rds_cluster.secondary.*.id)) | resource_id |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resource: aws_rds_cluster.secondary | ID:
BC_AWS_GENERAL_46How to Fix
Description
This check examines the attribute **backup_retention_period** this should have a value 1-35, and checks if its set to 0 which would disable the backup.This check is currently under review and maybe suppressed in future releases.
Dependent Resources