feat: AWS Asset Inventory Transformation #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonpr
changed the title
erezrokah
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
This looks good but you might want to add a GitHub workflow file like other packs and also the release configuration in https://github.com/cloudquery/policies-premium/blob/main/release-please-config.json
This was referenced Dec 5, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…342) 🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2023-12-06) ### Features * AWS Asset Inventory Transformation ([#327](#327)) ([6ef8e43](6ef8e43)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update of our legacy resources.sql (aws_resources) view to the new DBT framework. https://github.com/cloudquery/cloudquery/blob/main/plugins/source/aws/views/resources.sql
A couple changes:
Previously our free version (https://github.com/cloudquery/cloudquery/blob/main/plugins/source/aws/views/resources.sql) was checking information_schema.columns which also pulled in our AWS views that began with
aws_which led to errors. I pulled those out by checking pg_tables.This uses both a model and macros to add all resources in AWS tables to a resources view. There can be some cleanup on the code itself, but this should suffice for a first pass at the Asset Inventory View.
For this transformation, we'll offer it free as one of the starter transformations and visualizations.