-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Merge workflows, test on all available targets #400
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
126 changes: 126 additions & 0 deletions
126
.github/workflows/transformations_aws_asset_inventory_free.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| name: "Test AWS Asset Inventory Free Policies" | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "transformations/aws/asset-inventory-free/**" | ||
| - ".github/workflows/transformations_aws_asset_inventory_free.yml" | ||
| - "transformations/aws/macros/**" | ||
| - "transformations/aws/models/**" | ||
| - "transformations/macros/**" | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - "transformations/aws/asset-inventory-free/**" | ||
| - ".github/workflows/transformations_aws_asset_inventory_free.yml" | ||
| - "transformations/aws/macros/**" | ||
| - "transformations/aws/models/**" | ||
| - "transformations/macros/**" | ||
|
|
||
| env: | ||
| SNOW_USER: ${{ secrets.SNOW_USER }} | ||
| SNOW_PASSWORD: ${{ secrets.SNOW_PASSWORD }} | ||
| # DBT assumes the account is in the form of <account>.<region> | ||
| SNOW_ACCOUNT: "${{ secrets.SNOW_ACCOUNT }}.${{ secrets.SNOW_REGION }}" | ||
| SNOW_WAREHOUSE: ${{ secrets.SNOW_WAREHOUSE }} | ||
| SNOW_DATABASE: ${{ secrets.SNOW_DATABASE }} | ||
| SNOW_SCHEMA: ${{ secrets.SNOW_SCHEMA }} | ||
| SNOW_REGION: ${{ secrets.SNOW_REGION }} | ||
|
|
||
| jobs: | ||
| prepare: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| transformation_dir: ${{ fromJson(steps.set-result.outputs.result).transformation_dir }} | ||
| postgres: ${{ fromJson(steps.set-result.outputs.result).postgres }} | ||
| snowflake: ${{ fromJson(steps.set-result.outputs.result).snowflake }} | ||
| bigquery: ${{ fromJson(steps.set-result.outputs.result).bigquery }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - uses: actions/github-script@v7 | ||
| id: set-result | ||
| env: | ||
| TRANSFORMATION_DIR: transformations/aws/asset-inventory-free | ||
| with: | ||
| script: | | ||
| const fs = require('fs/promises'); | ||
| const { TRANSFORMATION_DIR: transformation_dir } = process.env; | ||
| const [postgres, snowflake, bigquery] = await Promise.all([ | ||
| fs.access(`${transformation_dir}/tests/postgres.yml`, fs.constants.F_OK).then(() => true).catch(() => false), | ||
| fs.access(`${transformation_dir}/tests/snowflake.yml`, fs.constants.F_OK).then(() => true).catch(() => false), | ||
| fs.access(`${transformation_dir}/tests/bigquery.yml`, fs.constants.F_OK).then(() => true).catch(() => false), | ||
| ]); | ||
| console.log(JSON.stringify({ transformation_dir, postgres, snowflake, bigquery })); | ||
| return { | ||
| transformation_dir, | ||
| postgres, | ||
| snowflake, | ||
| bigquery, | ||
| }; | ||
| transformations-aws-asset-inventory-free: | ||
| permissions: | ||
| id-token: 'write' | ||
| contents: 'read' | ||
| name: ${{ needs.prepare.outputs.transformation_dir }} | ||
| needs: prepare | ||
| timeout-minutes: 30 | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: ${{ needs.prepare.outputs.transformation_dir }} | ||
| services: | ||
| postgres: | ||
| image: postgres:11 | ||
| env: | ||
| POSTGRES_PASSWORD: pass | ||
| POSTGRES_USER: postgres | ||
| POSTGRES_DB: postgres | ||
| ports: | ||
| - 5432:5432 | ||
| # Set health checks to wait until postgres has started | ||
| options: >- | ||
| --health-cmd pg_isready | ||
| --health-interval 10s | ||
| --health-timeout 5s | ||
| --health-retries 5 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Authenticate to Google Cloud | ||
| uses: 'google-github-actions/auth@v1' | ||
| if: needs.prepare.outputs.bigquery == 'true' | ||
| with: | ||
| workload_identity_provider: 'projects/151868820337/locations/global/workloadIdentityPools/integration-test-pool/providers/integration-test-provider' | ||
| service_account: 'integration-service-account@cq-integration-tests.iam.gserviceaccount.com' | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.9" | ||
| cache: "pip" | ||
| cache-dependency-path: "${{ needs.prepare.outputs.transformation_dir }}/requirements.txt" | ||
| - name: Install dependencies | ||
| run: pip install -r requirements.txt | ||
| - name: Setup CloudQuery | ||
| uses: cloudquery/setup-cloudquery@v3 | ||
| with: | ||
| version: v4.3.2 | ||
| - name: Test Postgres | ||
| run: | | ||
| cloudquery migrate tests/postgres.yml | ||
| dbt run --target dev-pg --profiles-dir ./tests | ||
| if: needs.prepare.outputs.postgres == 'true' | ||
| env: | ||
| CQ_DSN: postgresql://postgres:pass@localhost:5432/postgres | ||
| - name: Test Snowflake | ||
| run: | | ||
| cloudquery migrate tests/snowflake.yml | ||
| dbt run --target dev-snowflake --profiles-dir ./tests | ||
| if: needs.prepare.outputs.snowflake == 'true' | ||
| env: | ||
| SNOWFLAKE_CONNECTION_STRING: "${{ secrets.SNOW_USER }}:${{ secrets.SNOW_PASSWORD }}@${{ secrets.SNOW_ACCOUNT }}.${{ secrets.SNOW_REGION }}/${{ secrets.SNOW_DATABASE }}/${{ secrets.SNOW_SCHEMA }}?warehouse=${{ secrets.SNOW_WAREHOUSE }}" | ||
| - name: Test BigQuery | ||
| if: needs.prepare.outputs.bigquery == 'true' | ||
| run: | | ||
| cloudquery migrate tests/bigquery.yml | ||
| dbt run --target dev-bigquery --profiles-dir ./tests |
64 changes: 0 additions & 64 deletions
64
.github/workflows/transformations_aws_asset_inventory_free_postgres.yml
This file was deleted.
Oops, something went wrong.
125 changes: 125 additions & 0 deletions
125
.github/workflows/transformations_aws_compliance_free.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| name: "Test AWS Compliance Free Policies" | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "transformations/aws/compliance-free/**" | ||
| - ".github/workflows/transformations_aws_compliance_free.yml" | ||
| - "transformations/aws/macros/**" | ||
| - "transformations/aws/models/**" | ||
| - "transformations/macros/**" | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - "transformations/aws/compliance-free/**" | ||
| - ".github/workflows/transformations_aws_compliance_free.yml" | ||
| - "transformations/aws/macros/**" | ||
| - "transformations/aws/models/**" | ||
| - "transformations/macros/**" | ||
|
|
||
| env: | ||
| SNOW_USER: ${{ secrets.SNOW_USER }} | ||
| SNOW_PASSWORD: ${{ secrets.SNOW_PASSWORD }} | ||
| # DBT assumes the account is in the form of <account>.<region> | ||
| SNOW_ACCOUNT: "${{ secrets.SNOW_ACCOUNT }}.${{ secrets.SNOW_REGION }}" | ||
| SNOW_WAREHOUSE: ${{ secrets.SNOW_WAREHOUSE }} | ||
| SNOW_DATABASE: ${{ secrets.SNOW_DATABASE }} | ||
| SNOW_SCHEMA: ${{ secrets.SNOW_SCHEMA }} | ||
| SNOW_REGION: ${{ secrets.SNOW_REGION }} | ||
|
|
||
| jobs: | ||
| prepare: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| transformation_dir: ${{ fromJson(steps.set-result.outputs.result).transformation_dir }} | ||
| postgres: ${{ fromJson(steps.set-result.outputs.result).postgres }} | ||
| snowflake: ${{ fromJson(steps.set-result.outputs.result).snowflake }} | ||
| bigquery: ${{ fromJson(steps.set-result.outputs.result).bigquery }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - uses: actions/github-script@v7 | ||
| id: set-result | ||
| env: | ||
| TRANSFORMATION_DIR: transformations/aws/compliance-free | ||
| with: | ||
| script: | | ||
| const fs = require('fs/promises'); | ||
| const { TRANSFORMATION_DIR: transformation_dir } = process.env; | ||
| const [postgres, snowflake, bigquery] = await Promise.all([ | ||
| fs.access(`${transformation_dir}/tests/postgres.yml`, fs.constants.F_OK).then(() => true).catch(() => false), | ||
| fs.access(`${transformation_dir}/tests/snowflake.yml`, fs.constants.F_OK).then(() => true).catch(() => false), | ||
| fs.access(`${transformation_dir}/tests/bigquery.yml`, fs.constants.F_OK).then(() => true).catch(() => false), | ||
| ]); | ||
| return { | ||
| transformation_dir, | ||
| postgres, | ||
| snowflake, | ||
| bigquery, | ||
| }; | ||
| transformations-aws-compliance-free: | ||
| permissions: | ||
| id-token: 'write' | ||
| contents: 'read' | ||
| name: ${{ needs.prepare.outputs.transformation_dir }} | ||
| needs: prepare | ||
| timeout-minutes: 30 | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: ${{ needs.prepare.outputs.transformation_dir }} | ||
| services: | ||
| postgres: | ||
| image: postgres:11 | ||
| env: | ||
| POSTGRES_PASSWORD: pass | ||
| POSTGRES_USER: postgres | ||
| POSTGRES_DB: postgres | ||
| ports: | ||
| - 5432:5432 | ||
| # Set health checks to wait until postgres has started | ||
| options: >- | ||
| --health-cmd pg_isready | ||
| --health-interval 10s | ||
| --health-timeout 5s | ||
| --health-retries 5 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Authenticate to Google Cloud | ||
| uses: 'google-github-actions/auth@v1' | ||
| if: needs.prepare.outputs.bigquery == 'true' | ||
| with: | ||
| workload_identity_provider: 'projects/151868820337/locations/global/workloadIdentityPools/integration-test-pool/providers/integration-test-provider' | ||
| service_account: 'integration-service-account@cq-integration-tests.iam.gserviceaccount.com' | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.9" | ||
| cache: "pip" | ||
| cache-dependency-path: "${{ needs.prepare.outputs.transformation_dir }}/requirements.txt" | ||
| - name: Install dependencies | ||
| run: pip install -r requirements.txt | ||
| - name: Setup CloudQuery | ||
| uses: cloudquery/setup-cloudquery@v3 | ||
| with: | ||
| version: v4.3.2 | ||
| - name: Test Postgres | ||
| run: | | ||
| cloudquery migrate tests/postgres.yml | ||
| dbt run --target dev-pg --profiles-dir ./tests --select aws_compliance__foundational_security_free | ||
| if: needs.prepare.outputs.postgres == 'true' | ||
| env: | ||
| CQ_DSN: postgresql://postgres:pass@localhost:5432/postgres | ||
| - name: Test Snowflake | ||
| run: | | ||
| cloudquery migrate tests/snowflake.yml | ||
| dbt run --target dev-snowflake --profiles-dir ./tests --select aws_compliance__foundational_security_free | ||
| if: needs.prepare.outputs.snowflake == 'true' | ||
| env: | ||
| SNOWFLAKE_CONNECTION_STRING: "${{ secrets.SNOW_USER }}:${{ secrets.SNOW_PASSWORD }}@${{ secrets.SNOW_ACCOUNT }}.${{ secrets.SNOW_REGION }}/${{ secrets.SNOW_DATABASE }}/${{ secrets.SNOW_SCHEMA }}?warehouse=${{ secrets.SNOW_WAREHOUSE }}" | ||
| - name: Test BigQuery | ||
| if: needs.prepare.outputs.bigquery == 'true' | ||
| run: | | ||
| cloudquery migrate tests/bigquery.yml | ||
| dbt run --target dev-bigquery --profiles-dir ./tests --select aws_compliance__foundational_security_free | ||
64 changes: 0 additions & 64 deletions
64
.github/workflows/transformations_aws_compliance_free_postgres.yml
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main change in this PR is to check for the relevant DB target specs and run migrate + DBT on each existing target. So you can add a new target to the CI by simply adding a
bigquery.ymlfile for example