Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade workflows to NodeJS 18+ #280

Closed
wants to merge 1 commit into from
Closed

chore: Upgrade workflows to NodeJS 18+ #280

wants to merge 1 commit into from

Conversation

timogasda
Copy link
Member

Description

Changes workflow to use NodeJS 18 for building. We're also upgrading the checkout action to v4 because it uses NodeJS 20 instead of 16: https://github.com/actions/checkout/releases/tag/v4.0.0. There is no version that uses NodeJS 18.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@timogasda timogasda requested a review from a team as a code owner October 18, 2023 11:54
@timogasda timogasda requested review from johannes-weber and removed request for a team October 18, 2023 11:54
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6f63f7a) 94.62% compared to head (49b585a) 93.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   94.62%   93.32%   -1.31%     
==========================================
  Files          15       15              
  Lines         689      689              
  Branches      176      176              
==========================================
- Hits          652      643       -9     
- Misses         31       40       +9     
  Partials        6        6              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timogasda
Copy link
Member Author

Closing in favor of #281

@timogasda timogasda closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant