Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix test coverage issues #297

Merged
merged 1 commit into from
Mar 25, 2024
Merged

chore: Fix test coverage issues #297

merged 1 commit into from
Mar 25, 2024

Conversation

just-boris
Copy link
Member

@just-boris just-boris commented Mar 21, 2024

Description

Fix coverage issues

  1. Switch to v8 provider because it provides more accurate numbers
  2. Rename vite.*config.mjs files to vite.config.*.mjs to follow the standard naming convention: https://github.com/vitest-dev/vitest/blob/fee7d8be9d6e6f710270600ae91fa35d861b7075/packages/vitest/src/defaults.ts#L6

Related links, issue #, if available: n/a

How has this been tested?

See PR build report, the coverage is finally above 90%

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (fd52d40) to head (5816a22).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   83.19%   91.18%   +7.99%     
==========================================
  Files          60       62       +2     
  Lines        1666     4310    +2644     
  Branches      446      728     +282     
==========================================
+ Hits         1386     3930    +2544     
- Misses        280      377      +97     
- Partials        0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris marked this pull request as ready for review March 21, 2024 15:13
@just-boris just-boris requested a review from a team as a code owner March 21, 2024 15:13
@just-boris just-boris requested review from michaeldowseza and removed request for a team March 21, 2024 15:13
@michaeldowseza
Copy link
Member

Switch to v8 provider because it provides more accurate numbers

Is it something we should consider for our other packages that currently use istanbul?

@just-boris
Copy link
Member Author

Yes, for all vitest based projects v8 is preferred.

@just-boris just-boris merged commit 8d46707 into main Mar 25, 2024
31 checks passed
@just-boris just-boris deleted the test-coverage branch March 25, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants