-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: RTL support for keyboard commands and pointer events #302
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 93.61% 93.60% -0.01%
==========================================
Files 62 62
Lines 4321 4444 +123
Branches 753 767 +14
==========================================
+ Hits 4045 4160 +115
- Misses 274 282 +8
Partials 2 2 ☔ View full report in Codecov by Sentry. |
direction = "right"; | ||
} else if (isRtl && direction === "right") { | ||
direction = "left"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better solution should be available here. Maybe it is easier to sort the "sources" differently depending on the page direction.
top: top + yOffset, | ||
bottom: bottom + yOffset, | ||
width: width, | ||
height: height, | ||
} as DOMRect; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DOMRect type is used in a bunch of places, it would be nice to replace it with some custom Rect type featuring rtl-friendly property names, maybe as a separate PR.
Description
Support for RTL
Observations:
Screen.Recording.2024-05-13.at.15.15.38.mov
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.