Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Makes board item test utils wrappers chainable #322

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Oct 2, 2024

Description

Board item has slots and those must return ElementWrapper and not ContentWrapper so that it is possible to chain selectors like createWrapper().findBoardItem().findContent().findButton(). That requires respective components selectors to be imported e.g. import "@cloudscape-design/components/test-utils/dom" or import "@cloudscape-design/code-view/test-utils/dom".

How has this been tested?

  • New unit tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot force-pushed the experiment-test-utils-inheritance branch 2 times, most recently from 573ba5f to 34ad46b Compare October 2, 2024 12:57
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (2a12041) to head (37e7506).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files          61       61           
  Lines        4312     4312           
  Branches      742      741    -1     
=======================================
  Hits         4035     4035           
  Misses        275      275           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot force-pushed the experiment-test-utils-inheritance branch from 9e74bd3 to 37e7506 Compare October 8, 2024 07:31
@pan-kot pan-kot marked this pull request as ready for review October 8, 2024 07:33
@pan-kot pan-kot requested a review from a team as a code owner October 8, 2024 07:34
@pan-kot pan-kot requested review from just-boris and removed request for a team October 8, 2024 07:34
@pan-kot pan-kot changed the title chore: Experiment test utils inheritance fix: Makes board item test utils wrappers chainable Oct 8, 2024
@pan-kot pan-kot added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@pan-kot pan-kot added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 1fa5450 Oct 8, 2024
36 of 37 checks passed
@pan-kot pan-kot deleted the experiment-test-utils-inheritance branch October 8, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants