Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make window taller in test to avoid scrollbars #329

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jperals
Copy link
Member

@jperals jperals commented Nov 13, 2024

Description

We want to show scrollbars in tests but one test in board-components fails when doing that (dry-run). This is because as the element is dragged, grid placeholders are added below, which causes a scrollbar to appear and the page content slightly moves to the left. Then, the test, which compares the dragged element's position against the placeholders, does not find it exactly where it expects.

I don't think this is really a bug, rather expected behavior given how browsers work. Therefore fixing in the test.

How has this been tested?

Used this approach to show scrollbars locally. Ran the changed test before the changes and it failed, and after the changes it passed.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals jperals requested a review from a team as a code owner November 13, 2024 15:43
@jperals jperals requested review from taheramr and removed request for a team November 13, 2024 15:43
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (97dee37) to head (048f317).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #329    +/-   ##
========================================
  Coverage   93.97%   93.97%            
========================================
  Files          61       61            
  Lines        4312     4312            
  Branches      532      744   +212     
========================================
  Hits         4052     4052            
+ Misses        260      258     -2     
- Partials        0        2     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jperals jperals added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit c2dd86b Dec 6, 2024
41 of 42 checks passed
@jperals jperals deleted the chore/test-window-height branch December 6, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants