chore: Make window taller in test to avoid scrollbars #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to show scrollbars in tests but one test in board-components fails when doing that (dry-run). This is because as the element is dragged, grid placeholders are added below, which causes a scrollbar to appear and the page content slightly moves to the left. Then, the test, which compares the dragged element's position against the placeholders, does not find it exactly where it expects.
I don't think this is really a bug, rather expected behavior given how browsers work. Therefore fixing in the test.
How has this been tested?
Used this approach to show scrollbars locally. Ran the changed test before the changes and it failed, and after the changes it passed.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.