Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix package build #22

Merged
merged 1 commit into from
Mar 6, 2024
Merged

chore: Fix package build #22

merged 1 commit into from
Mar 6, 2024

Conversation

just-boris
Copy link
Member

@just-boris just-boris commented Mar 6, 2024

Description

Fix build issues

  1. Rollup dependency issue: https://github.com/cloudscape-design/code-view/actions/runs/8017473637/job/21901416721#step:6:77

Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (npm/cli#4828). Please try npm i again after removing both package-lock.json and node_modules directory.

Rebuilt the lockfile and it worked

  1. Fix test coverage reporting issues, porting fixes from chore: Fix test coverage config board-components#295

How has this been tested?

Build passes now

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (9f814a2) to head (3842414).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #22       +/-   ##
==========================================
+ Coverage   0.00%   72.72%   +72.72%     
==========================================
  Files          9        9               
  Lines         63       66        +3     
  Branches      17       17               
==========================================
+ Hits           0       48       +48     
+ Misses        56       17       -39     
+ Partials       7        1        -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris marked this pull request as ready for review March 6, 2024 15:03
@just-boris just-boris requested a review from a team as a code owner March 6, 2024 15:03
@just-boris just-boris requested review from connorlanigan and removed request for a team March 6, 2024 15:03
@just-boris just-boris merged commit 20271b2 into main Mar 6, 2024
29 of 32 checks passed
@just-boris just-boris deleted the fix-build branch March 6, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants