Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix line numbers misalignment with single-line content when actions are provided #43

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

avinashbot
Copy link
Member

@avinashbot avinashbot commented Sep 10, 2024

Description

We add a min height to the content when actions aren't provided, but we don't add that min height to the line numbers container, so it doesn't match. This happens with both themes.

Related links, issue #, if available: AWSUI-58645

How has this been tested?

Added a screenshot test for line numbers and actions.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d4475dc) to head (77f7e79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          345       348    +3     
  Branches        30        31    +1     
=========================================
+ Hits           345       348    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avinashbot avinashbot marked this pull request as ready for review September 10, 2024 10:46
@avinashbot avinashbot requested a review from a team as a code owner September 10, 2024 10:46
@avinashbot avinashbot requested review from dpitcock and removed request for a team September 10, 2024 10:46
@avinashbot avinashbot added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 93b9ccb Sep 13, 2024
34 of 35 checks passed
@avinashbot avinashbot deleted the fix-line-numbers-actions branch September 13, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants