-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Supporting webdriverio v9 migration 3 #2763
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2763 +/- ##
========================================
Coverage 96.02% 96.02%
========================================
Files 749 749
Lines 20914 20916 +2
Branches 7126 6751 -375
========================================
+ Hits 20082 20084 +2
Misses 824 824
Partials 8 8 ☔ View full report in Codecov by Sentry. |
6a9aa52
to
bc76e6c
Compare
bc76e6c
to
9e26a73
Compare
9e26a73
to
a94e789
Compare
return expect(liveRegion.getHTML(false)).resolves.toBe(announcement); | ||
return expect(liveRegion.getHTML()).resolves.toContain(announcement); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The getHTML() api changes. In v7 it took a flag and in v9 it takes an object.
When the flag is provided it returns the inner part of the node only. When not provided - the entire node. That's why I changed toBe to toContain. We can change this back when the webdriver dependency is updated, although that is not really necessary.
Description
This fixes remaining incompatibility issues. The PR is a follow-up for: #2753
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.