Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Supporting webdriverio v9 migration 3 #2763

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Sep 25, 2024

Description

This fixes remaining incompatibility issues. The PR is a follow-up for: #2753

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (4b05e5d) to head (a94e789).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2763    +/-   ##
========================================
  Coverage   96.02%   96.02%            
========================================
  Files         749      749            
  Lines       20914    20916     +2     
  Branches     7126     6751   -375     
========================================
+ Hits        20082    20084     +2     
  Misses        824      824            
  Partials        8        8            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot force-pushed the chore-webdriverio9-3 branch from 9e26a73 to a94e789 Compare September 25, 2024 09:14
@pan-kot pan-kot changed the title chore: Resolve incompatibilities with webdriverio 9 chore: Supporting webdriverio v9 migration 3 Sep 25, 2024
@pan-kot pan-kot marked this pull request as ready for review September 25, 2024 10:22
@pan-kot pan-kot requested a review from a team as a code owner September 25, 2024 10:22
@pan-kot pan-kot requested review from cansuaa and removed request for a team September 25, 2024 10:22
return expect(liveRegion.getHTML(false)).resolves.toBe(announcement);
return expect(liveRegion.getHTML()).resolves.toContain(announcement);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getHTML() api changes. In v7 it took a flag and in v9 it takes an object.

When the flag is provided it returns the inner part of the node only. When not provided - the entire node. That's why I changed toBe to toContain. We can change this back when the webdriver dependency is updated, although that is not really necessary.

@pan-kot pan-kot added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit d596448 Sep 26, 2024
36 checks passed
@pan-kot pan-kot deleted the chore-webdriverio9-3 branch September 26, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants