-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent dropdown misplacement in iOS #3202
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3202 +/- ##
==========================================
+ Coverage 96.42% 96.44% +0.01%
==========================================
Files 787 788 +1
Lines 22191 22186 -5
Branches 7555 7613 +58
==========================================
- Hits 21398 21397 -1
+ Misses 741 737 -4
Partials 52 52 ☔ View full report in Codecov by Sentry. |
f59383b
to
ef671e1
Compare
9a0c7c1
to
731bb5c
Compare
This reverts commit 5b9cecc.
1599f44
to
aa7c16f
Compare
position: { ...baseDropdownPosition, dropBlockStart: true }, | ||
isMobile: false, | ||
}); | ||
expect(dropdownElement.style.insetBlockEnd).toBeTruthy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a couple cases (here and 3 tests further down) I'm testing just that a value is set (truthy), instead of the actual value. This is because the value is a CSS expression using calc()
, and I don't think it makes sense to be so specific about the implementation. We already have visual regression tests for the expected user-facing end result, which is what matters.
Description
Issue:
AWSUI-59635
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.