Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent dropdown misplacement in iOS #3202

Merged
merged 11 commits into from
Jan 23, 2025
Merged

Conversation

jperals
Copy link
Member

@jperals jperals commented Jan 16, 2025

Description

Issue: AWSUI-59635

How has this been tested?

  • Manually, on real iOS device and with Chrome's mobile simulator
  • Ran the changes on my pipeline
  • Added unit tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (372abbd) to head (69c6207).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3202      +/-   ##
==========================================
+ Coverage   96.42%   96.44%   +0.01%     
==========================================
  Files         787      788       +1     
  Lines       22191    22186       -5     
  Branches     7555     7613      +58     
==========================================
- Hits        21398    21397       -1     
+ Misses        741      737       -4     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jperals jperals force-pushed the fix/dropdown-ios-position branch from 1599f44 to aa7c16f Compare January 22, 2025 13:00
position: { ...baseDropdownPosition, dropBlockStart: true },
isMobile: false,
});
expect(dropdownElement.style.insetBlockEnd).toBeTruthy();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a couple cases (here and 3 tests further down) I'm testing just that a value is set (truthy), instead of the actual value. This is because the value is a CSS expression using calc(), and I don't think it makes sense to be so specific about the implementation. We already have visual regression tests for the expected user-facing end result, which is what matters.

@jperals jperals marked this pull request as ready for review January 22, 2025 13:55
@jperals jperals requested a review from a team as a code owner January 22, 2025 13:55
@jperals jperals requested review from michaeldowseza and removed request for a team January 22, 2025 13:55
@jperals jperals added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 3839ca0 Jan 23, 2025
38 checks passed
@jperals jperals deleted the fix/dropdown-ios-position branch January 23, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants