Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable path keys in hints #250

Merged

Conversation

makenowjust
Copy link
Collaborator

Fix #242

It is a breaking change due to modifying the AST node structure.

@apstndb Could you review this PR?

Fix cloudspannerecosystem#242

It is a breaking change due to modifying the AST node structure.
Copy link
Contributor

@apstndb apstndb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@makenowjust makenowjust merged commit f71f971 into cloudspannerecosystem:main Jan 2, 2025
2 checks passed
@makenowjust
Copy link
Collaborator Author

Thank you @apstndb.

@makenowjust makenowjust deleted the fix/242-path-hints branch January 2, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support path hint keys
2 participants