Add support for ALTER INDEX statement #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toga4
commented
Oct 21, 2023
| @@ -292,6 +294,15 @@ func (ScalarSchemaType) isSchemaType() {} | |||
| func (SizedSchemaType) isSchemaType() {} | |||
| func (ArraySchemaType) isSchemaType() {} | |||
|
|
|||
| // IndexAlternation represents ALTER INDEX action. | |||
| type IndexAlternation interface { | |||
There was a problem hiding this comment.
While implementing this, I noticed that what might typically be named as Alteration is named as Alternation in the existing code. For consistency, I continued with the name Alternation in my changes. However, it might be worth reviewing this naming for clarity in future updates.
There was a problem hiding this comment.
It sounds good. I would like you to leave them as Alternation for now and fix them after merging this PR.
There was a problem hiding this comment.
OK, I'll raise another PR.
makenowjust
requested changes
Oct 22, 2023
|
@toga4 Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ALTER INDEX statement.