-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --ignore-unsupported-statements flag #116
add --ignore-unsupported-statements flag #116
Conversation
ebd00cb
to
23dc7f2
Compare
even if ignore-unsupported-statements is true
It seems the improvement of statements separation is good but it's the same problem I commented in the issue in the wrench repo. |
I think so too.
I think, if user has below file:
currently,
If we use new feature in Or do you mean another problem occurs? |
I modified code:
|
…ture/add-skip-invalid-statement-option
I close this ticket. |
WHAT
--ignore-unsupported-statements
flag to v2yo generate
command.Context
When user manages several DDLs in one schema file,
user should filter DDLs to pass
yo generate
whichyo
doesn't support.This makes it difficult for user to use DDLs that
yo
does not support.--ignore-unsupported-statements
flag enablesyo
to skip these statements, and continue to generate codes.And if the user really made a mistake in supported syntax in DDL such as
CREATE TABLE
,CREATE INDEX
,ALTER TABLE
, this case still failed.Therefore, I don't think adding this flag will make it easy for users to make problems.
How do you think?
ref:
cloudspannerecosystem/wrench#83
I agreeed CLA.
Thank you!