Skip to content

Commit

Permalink
Merge pull request cdapio#255 from cloudsufi/pipelineLogs-fix
Browse files Browse the repository at this point in the history
close pipeline logs fix
  • Loading branch information
itsankit-google authored Dec 7, 2024
2 parents da76ba3 + 3fccdc8 commit 4d27679
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/main/java/io/cdap/e2e/pages/actions/CdfLogActions.java
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,6 @@ public static void verifyPipelineFailedLogIsShownWithErrorLevel() {
* Click on the close button(x) for the Logs page
*/
public static void closeLogs() {
ElementHelper.clickOnElement(CdfLogLocators.closeLogs);
ElementHelper.clickIfDisplayed(CdfLogLocators.closeLogs);
}
}
4 changes: 1 addition & 3 deletions src/main/java/io/cdap/e2e/pages/locators/CdfLogLocators.java
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ public class CdfLogLocators {

@FindBy(xpath = "//*[contains(text(),'Pipeline') and contains(text(),'succeeded')]")
public static WebElement validateSucceeded;

@FindBy(xpath = "//*[contains(@class, 'close')]")
public static WebElement closeLogs;
public static By closeLogs = By.xpath("//*[contains(@class, 'close')]");

public static WebElement getPipelineStatusFromLogs(String status) {
return SeleniumDriver.getDriver()
Expand Down

0 comments on commit 4d27679

Please sign in to comment.