Framework steps for Hub phase 2 #17
Conversation
AnkitCLI
force-pushed
the
e2e-hub-tests-2
branch
2 times, most recently
from
1218570 to
eb04ee8
Compare
| public static void clickOnTheSideOptions(String option) { | ||
| CdfHubActions.clickOnSideOptions(option); | ||
| } | ||
| @Then("Click on the {string} option from the list panel") |
There was a problem hiding this comment.
Are these both steps referring to the same or you are achieving two different actions.
There was a problem hiding this comment.
Yes, these both steps are referring to two different actions.
| public static void clickOnCloseButton() { | ||
| ElementHelper.clickOnElement(CdfHubLocators.closeButton); | ||
| } | ||
| public static void clickOnSearchTab(String message) { |
There was a problem hiding this comment.
provide a name like searchedText instead of message
| } | ||
| ElementHelper.isElementDisplayed(CdfHubLocators.locatePlugin(pluginPropertyDataCyAttribute)); | ||
| } | ||
| public static void clickOnSideOptions(String option) { |
There was a problem hiding this comment.
provide a specific name which can be understandable .
| CdfHubLocators.locateDropdownListItem( | ||
| optionFromPluginPropertiesFile)); | ||
| } | ||
| public static void clickOnSearchTabControlCenter(String message) { |
There was a problem hiding this comment.
change message to searchedText/searchedElement
| if (pluginPropertyDataCyAttribute == null) { | ||
| pluginPropertyDataCyAttribute = pluginProperty; | ||
| } | ||
|
|
There was a problem hiding this comment.
is space needed here ?
| ElementHelper.selectDropdownOption(CdfPluginPropertiesLocators | ||
| .locatePropertyElement(pluginPropertyDataCyAttribute), | ||
| CdfHubLocators.locateDropdownListItem(option)); | ||
| return; |
There was a problem hiding this comment.
for void methods we are not returning anything , why this return is provided ?
| public static void clickOnTheOption(String button) { | ||
| CdfHubActions.clickOnButton(button); | ||
| } | ||
| @Then("Verify that {string} pipeline is saved in Drafts") |
| public static WebElement locatePlugin(String pluginName) { | ||
| return SeleniumDriver.getDriver() | ||
| .findElement(By.xpath("//*[contains(text(),'" + pluginName + "')]")); | ||
| } |
There was a problem hiding this comment.
add space after each methods
There was a problem hiding this comment.
line number 58,62,65,68,71,74
| @Then("Click on Hub Menu") | ||
| public static void openHub() { | ||
| CdfHubActions.clickOnHub(); | ||
| } |
There was a problem hiding this comment.
Add space post each actions is declared . line number 39,43,47 and so on ..
|
|
||
| public static void clickOnHub() { | ||
| ElementHelper.clickOnElement(CdfHubLocators.hubPage); | ||
| } |
There was a problem hiding this comment.
add space post this line and post subsequesnt closing lines for all other methods
| public static void clickOnDeploy() { | ||
| ElementHelper.clickOnElement(CdfHubLocators.deployButton); | ||
| } | ||
| public static void clickOnFinish() { |
There was a problem hiding this comment.
Provide some info in comment before starting of actions that what is doing .
/**
- Click on Finish button to deploy the plugin Or create the pipline .
*/
Please provide this type of info in comments for each and every actions
| @@ -41,6 +41,10 @@ public static void openHub() { | |||
| public static void openPlugin(String pluginName) { | |||
| CdfHubActions.clickOnPlugin(pluginName); | |||
| } | |||
| @Then("Click on {string} pipeline") | |||
| public static void openPipeline(String pipelineName) { | |||
| CdfHubActions.clickOnPlugin(pipelineName); | |||
There was a problem hiding this comment.
Is this a plugin or pipeline? Please use proper naming.
| CdfHubActions.clickOnHamburgerMenu(); | ||
| } | ||
| @Then("Click on the {string} from the left panel") | ||
| public static void clickOnTheSideOptions(String option) { |
There was a problem hiding this comment.
Its hamburger menu option
There was a problem hiding this comment.
it is not for hamburger menu it is for the options inside hamburger so i have change it to clickOnOptionFromHamburgerMenu
| } | ||
| @Then("Click on the {string} from the left panel") | ||
| public static void clickOnTheSideOptions(String option) { | ||
| CdfHubActions.clickOnSideOptions(option); |
There was a problem hiding this comment.
Change as above clickOnHamburgerMenuOption
| /** | ||
|
|
||
| Click on Close button to close the hub page . | ||
| */ |
There was a problem hiding this comment.
There should not be any space in 89 and * should be present before start of sentence
AnkitCLI
force-pushed
the
e2e-hub-tests-2
branch
from
ddb2ae0 to
c900bd1
Compare
AnkitCLI
force-pushed
the
e2e-hub-tests-2
branch
2 times, most recently
from
d8e96a1 to
f10d1a5
Compare
AnkitCLI
force-pushed
the
e2e-hub-tests-2
branch
from
f10d1a5 to
d227265
Compare
No description provided.