Functionality added for GCS delete multipart upload policy #18

neerajsinghal05 · 2023-11-09T16:04:29Z

Functionality added for GCS delete multipart upload policy

itsmekumari · 2023-11-10T07:05:12Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

@@ -40,7 +45,8 @@ public class StorageClient {

  private static Storage getStorageService() throws IOException {
    return (null == storageService) ? StorageOptions.newBuilder().setProjectId(
-      PluginPropertyUtils.pluginProp(ConstantsUtil.PROJECT_ID)).build().getService() : storageService;
+        PluginPropertyUtils.pluginProp(ConstantsUtil.PROJECT_ID)).build().getService()


If there is no change in code, revert them this should not be shown in PR.

Changes has been done , as per the review comment

rahuldash171

Please address review comments

rahuldash171 · 2023-11-10T06:44:29Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

@@ -40,7 +45,8 @@ public class StorageClient {

  private static Storage getStorageService() throws IOException {
    return (null == storageService) ? StorageOptions.newBuilder().setProjectId(
-      PluginPropertyUtils.pluginProp(ConstantsUtil.PROJECT_ID)).build().getService() : storageService;
+        PluginPropertyUtils.pluginProp(ConstantsUtil.PROJECT_ID)).build().getService()
+        : storageService;


why the writing format has been changed if there is no change ?

Changes has been done , as per the review comment

rahuldash171 · 2023-11-10T06:45:33Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

@@ -52,7 +58,7 @@ public static Page<Blob> listObjects(String bucketName) throws IOException {
  }

  public static Page<Blob> listObjectsWithPrefix(
-    String bucketName, String directoryPrefix) throws IOException {
+      String bucketName, String directoryPrefix) throws IOException {


remove space so that it can not be seen as a new line

Changes has been done , as per the review comment

rahuldash171 · 2023-11-10T06:49:21Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

-    return getStorageService().get(bucketName, blobName, Storage.BlobGetOption.fields(Storage.BlobField.values()));
+      throws StorageException, IOException {
+    return getStorageService().get(bucketName, blobName,
+        Storage.BlobGetOption.fields(Storage.BlobField.values()));
  }


remove new line , no change here too, work on spaces . format should not be changed for existing code

rahuldash171 · 2023-11-10T06:51:18Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

  }

  public static Bucket getBucketMetadata(String bucketName) throws IOException {
-    return getStorageService().get(bucketName, Storage.BucketGetOption.fields(Storage.BucketField.values()));
+    return getStorageService().get(bucketName,
+        Storage.BucketGetOption.fields(Storage.BucketField.values()));


Same here , dont change existing code

Changes has been done , as per the review comment

rahuldash171 · 2023-11-10T06:53:59Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

@@ -87,10 +95,18 @@ public static Bucket createBucket(String bucketName) throws IOException {
  }

  public static Blob uploadObject(String bucketName, String objectName, String filePath)
-    throws IOException, URISyntaxException {
+      throws IOException, URISyntaxException {


Same here , undo the changes

rahuldash171 · 2023-11-10T08:24:23Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

-      BlobInfo.newBuilder(BlobId.of(bucketName, objectName)).build(),
-      Files.readAllBytes(Paths.get(StorageClient.class.getResource("/" + filePath).toURI())));
+        BlobInfo.newBuilder(BlobId.of(bucketName, objectName)).build(),
+        Files.readAllBytes(Paths.get(StorageClient.class.getResource("/" + filePath).toURI())));


Same here , undo the changes

change is not seen it is still seen as new line

Changes has been done , as per the review comment

rahuldash171 · 2023-11-10T08:28:04Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

+            ImmutableList.of(
+                new LifecycleRule(
+                    LifecycleAction.newAbortIncompleteMPUploadAction(),
+                    LifecycleCondition.newBuilder().setAge(age).build()))).build().update(); }


Add the curly braces below and there should be a space between the final and this curly braces after you change .
LifecycleCondition.newBuilder().setAge(age).build()))).build().update();
}

}

resolve this .

Changes has been done , as per the review comment

rahuldash171 · 2023-11-14T07:45:02Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

+            ImmutableList.of(
+                new LifecycleRule(
+                    LifecycleAction.newAbortIncompleteMPUploadAction(),
+                    LifecycleCondition.newBuilder().setAge(age).build()))).build().update(); }


resolve this .

rahuldash171 · 2023-11-14T07:45:25Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

-      BlobInfo.newBuilder(BlobId.of(bucketName, objectName)).build(),
-      Files.readAllBytes(Paths.get(StorageClient.class.getResource("/" + filePath).toURI())));
+        BlobInfo.newBuilder(BlobId.of(bucketName, objectName)).build(),
+        Files.readAllBytes(Paths.get(StorageClient.class.getResource("/" + filePath).toURI())));


change is not seen it is still seen as new line

rahuldash171 · 2023-11-14T07:45:39Z

src/main/java/io/cdap/e2e/utils/StorageClient.java

@@ -40,7 +45,7 @@ public class StorageClient {

  private static Storage getStorageService() throws IOException {
    return (null == storageService) ? StorageOptions.newBuilder().setProjectId(
-      PluginPropertyUtils.pluginProp(ConstantsUtil.PROJECT_ID)).build().getService() : storageService;
+        PluginPropertyUtils.pluginProp(ConstantsUtil.PROJECT_ID)).build().getService() : storageService;


new line is seeen here too

Changes has been done , as per the review comment

rahuldash171

Approved .

neerajsinghal05 requested a review from Vipinofficial11 November 10, 2023 07:05

itsmekumari reviewed Nov 10, 2023

View reviewed changes

neerajsinghal05 requested a review from rahuldash171 November 10, 2023 07:05

rahuldash171 reviewed Nov 10, 2023

View reviewed changes

rahuldash171 reviewed Nov 14, 2023

View reviewed changes

neerajsinghal05 force-pushed the Multi_upload_Policy branch 2 times, most recently from dc1d1f6 to 9ae52cd Compare November 14, 2023 12:33

rahuldash171 approved these changes Nov 14, 2023

View reviewed changes

neerajsinghal05 force-pushed the Multi_upload_Policy branch from b7f08c0 to b20b5f2 Compare November 28, 2023 04:29

Functionality added for GCS multipart upload policy.

51422f5

neerajsinghal05 force-pushed the Multi_upload_Policy branch from b20b5f2 to 51422f5 Compare November 28, 2023 06:02

rahuldash171 merged commit 44f61d8 into develop Nov 28, 2023
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Functionality added for GCS delete multipart upload policy #18

Functionality added for GCS delete multipart upload policy #18

neerajsinghal05 commented Nov 9, 2023

itsmekumari Nov 10, 2023

neerajsinghal05 Nov 14, 2023

rahuldash171 left a comment

rahuldash171 Nov 10, 2023

neerajsinghal05 Nov 14, 2023

rahuldash171 Nov 10, 2023

neerajsinghal05 Nov 14, 2023

rahuldash171 Nov 10, 2023

neerajsinghal05 Nov 13, 2023

rahuldash171 Nov 10, 2023

neerajsinghal05 Nov 14, 2023

rahuldash171 Nov 10, 2023

rahuldash171 Nov 10, 2023

neerajsinghal05 Nov 13, 2023

rahuldash171 Nov 14, 2023

neerajsinghal05 Nov 14, 2023

rahuldash171 Nov 10, 2023

rahuldash171 Nov 14, 2023

neerajsinghal05 Nov 14, 2023

rahuldash171 Nov 14, 2023

rahuldash171 Nov 14, 2023

rahuldash171 Nov 14, 2023

neerajsinghal05 Nov 14, 2023

rahuldash171 left a comment

Functionality added for GCS delete multipart upload policy #18

Functionality added for GCS delete multipart upload policy #18

Conversation

neerajsinghal05 commented Nov 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rahuldash171 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rahuldash171 left a comment

Choose a reason for hiding this comment