PLUGIN-1851 -CloudSQL MySQL Incorrect source and sink plugin name #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the error message
Corrected the error message
psainics
reviewed
Jan 27, 2025
database-commons/src/main/java/io/cdap/plugin/util/CloudSQLUtil.java
Outdated
Show resolved
Hide resolved
|
Since you have made changes to action plugins can you add those as well in screenshot, and add label to these screenshots. |
Added and labeled SS |
psainics
approved these changes
Jan 27, 2025
|
Upstreme PR : data-integrations#545 |
|
Upstream PR Merged : data-integrations#545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLUGIN-1851
Description
CloudSQLMySQL source/sink-Irrelevant Plugin name displayed on the in-line error message with invalid connection name
Ref-
Tests- Invalid connection name for MySQL and PostgreSQL source and sink plugin with private and public instances
Cloud MySQL source -public
Cloud MySQL source -private
Cloud MySQL sink -public
Cloud MySQL sink -private
Cloud PostgreSQL source -public
Cloud PostgreSQL source -private
Cloud PostgreSQL sink -public
Cloud PostgreSQL sink -private
Cloud MySQL action -public
Cloud MySQL action -private
Cloud PostgreSQL action -public
Cloud PostgreSQL action -private