feat: add config_generator for cwgo/pkg

cloudwego · Aug 10, 2024 · 91b28c5 · 91b28c5
1 parent 232b14b
commit 91b28c5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/pkg/config_generator/metadata.go b/pkg/config_generator/metadata.go
@@ -16,12 +16,6 @@
 
 package config_generator
 
-const (
-	Yaml = "yaml"
-	Json = "json"
-	Text = "text"
-)
-
 type ConfigGenerateMeta struct {
 	Desc            string          `json:"desc,omitempty"`
 	Kind            string          `json:"kind,omitempty"`

diff --git a/pkg/config_generator/yaml2go.go b/pkg/config_generator/yaml2go.go
@@ -26,13 +26,13 @@ import (
 )
 
 // New creates Yaml2Go object
-func New(key, desc, kind string, fileType ConfigValueType) Yaml2Go {
+func New(key, desc, kind string, configValueType ConfigValueType) Yaml2Go {
 	return Yaml2Go{
 		StructsMeta: &ConfigGenerateMeta{
 			Key:             key,
 			Kind:            kind,
 			Desc:            desc,
-			ConfigValueType: fileType,
+			ConfigValueType: configValueType,
 			structTree:      make(map[string]Struct),
 		},
 	}

diff --git a/pkg/config_generator/yaml2go_test.go b/pkg/config_generator/yaml2go_test.go
@@ -32,7 +32,7 @@ kitex:
 `
 
 func TestYaml2Go(t *testing.T) {
-	yaml2Go := New("key", "desc", "group", "YamlType")
+	yaml2Go := New("key", "desc", "group", ConfigValueType_YamlType)
 	s, err := yaml2Go.Convert("config", []byte(value))
 	if err != nil {
 		t.Fatal(err)