feat: refine mongo #183
Closed
feat: refine mongo #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hu.guanjun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
gofumpt -e -d -w -extra . 格式化一下代码，CI 没过 |
chaoranz758
reviewed
Apr 30, 2024
| @@ -35,5 +35,6 @@ func clientFlags() []cli.Flag { | |||
| &cli.StringSliceFlag{Name: consts.ProtoSearchPath, Aliases: []string{"I"}, Usage: "Add an IDL search path for includes. (Valid only if idl is protobuf)"}, | |||
| &cli.StringSliceFlag{Name: consts.Pass, Usage: "pass param to hz or kitex"}, | |||
| &cli.BoolFlag{Name: consts.Verbose, Usage: "Turn on verbose mode."}, | |||
| &cli.BoolFlag{Name: consts.GenBase, Usage: "Generate base mongo code, default is false."}, | |||
There was a problem hiding this comment.
cwgo client 的参数应该是多余的吧，删掉
chaoranz758
reviewed
Apr 30, 2024
pkg/curd/code/base_params.go
Outdated
| @@ -0,0 +1,258 @@ | |||
| /* | |||
There was a problem hiding this comment.
这个文件放到 doc/mongo/codegen 下比较合适，有些变量可以复用，如 ctx selector 等，可以整理一下
* fix: delete redundant file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it (en: English/zh: Chinese):
en:
zh:
Which issue(s) this PR fixes: