feat: support cwgo generate code && service registry extension #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rogerogers |
3 tasks
rogerogers
reviewed
Nov 27, 2023
| } | ||
| } | ||
|
|
||
| func resolverConfig() []*survey.Question { |
There was a problem hiding this comment.
Why is it called a resolver? Most people are more familiar with the term "registry center".
There was a problem hiding this comment.
On the client side, service resolver maybe better?
There was a problem hiding this comment.
Skyenought
reviewed
Nov 28, 2023
| Redistribution and use in source and binary forms, with or without | ||
| modification, are permitted provided that the following conditions are | ||
| met: | ||
|
|
There was a problem hiding this comment.
既然引入了 gofumpt, 使用以下类似的方法使用 gofumpt 怎么样
Skyenought
reviewed
Nov 28, 2023
| ca.Registry != consts.Etcd && | ||
| ca.Registry != consts.Polaris { | ||
| return errors.New("unsupported registry") | ||
| if ca.Resolver != "" && |
There was a problem hiding this comment.
这里不应该使用 || 吗?
假定就是 ||, 我觉得可以把这些 registry consts 写成一个切片, 循环进行比对
Skyenought
reviewed
Nov 28, 2023
pkg/generator/hz_client_tpl.go
Outdated
| import "github.com/cloudwego/cwgo/pkg/consts" | ||
|
|
||
| // related to service resolver | ||
| var ( |
There was a problem hiding this comment.
其实这类文件是 registry 的 tpl 文件, 要不将这类文件的名字改为 hz_client_registry_tpl.go 之类的?
chaoranz758
force-pushed
the
feat_registry
branch
from
ca8e9bc to
3c5dd4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
What this PR does / why we need it (en: English/zh: Chinese):
en: feat: support cwgo generate code && service registry extension
zh:支持 cwgo 生成代码的能力 && 集成 cwgo 服务注册与发现的能力 && 用户可自定义服务注册与发现扩展
Which issue(s) this PR fixes:
#106