refactor: callbacks #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 148 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 145 | 3 | 0 | 0 |
Click to see the invalid file list
- internal/callbacks/inject.go
- internal/callbacks/interface.go
- internal/callbacks/manager.go
luohq-bytedance
requested review from
N3kox,
meguminnnnnnnnn,
BytePender and
shentongmartin
luohq-bytedance
force-pushed
the
luohq/refactor
branch
from
b261fab to
408da8c
Compare
There was a problem hiding this comment.
license-eye has totally checked 148 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 145 | 3 | 0 | 0 |
Click to see the invalid file list
- internal/callbacks/inject.go
- internal/callbacks/interface.go
- internal/callbacks/manager.go
|
go-test-coverage report: |
luohq-bytedance
force-pushed
the
luohq/refactor
branch
2 times, most recently
from
a01006a to
6296427
Compare
-- move some code into internal/callbacks -- rm deprecated code -- refactor duplicated code Change-Id: I443b3074426bf406c4ad68ad027f1f9e143b288f
luohq-bytedance
force-pushed
the
luohq/refactor
branch
from
6296427 to
2bdbe1a
Compare
|
merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- move some code into internal/callbacks
-- rm deprecated code
-- refactor duplicated code
Change-Id: I443b3074426bf406c4ad68ad027f1f9e143b288f
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: