Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't override include_dirs for protobuf config #232

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: don't override include_dirs for protobuf config #232

merged 1 commit into from
Mar 26, 2024

Conversation

Millione
Copy link
Member

Motivation

Compilation will fail when there are multiple different include_dirs configurations.

Solution

Extend include_dirs instead of override.

@Millione Millione requested review from a team as code owners March 26, 2024 09:08
@Millione Millione merged commit ce01c86 into cloudwego:main Mar 26, 2024
9 checks passed
@Millione Millione deleted the fix/includes branch March 26, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukiiiteru yukiiiteru yukiiiteru approved these changes

@PureWhiteWu PureWhiteWu PureWhiteWu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Millione @PureWhiteWu @yukiiiteru