Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to the official protobuf-parse. #242

Closed
wants to merge 1 commit into from

Conversation

liuxin231
Copy link
Contributor

Motivation

Switch to the official protobuf-parse.

#3

@liuxin231 liuxin231 requested review from a team as code owners April 24, 2024 12:30
@PureWhiteWu
Copy link
Member

Hi, thanks very much for your contribution!

We have some other improvements and bug fixes in our version, you may refer to the commits: https://github.com/LYF1999/rust-protobuf/commits/protobuf2/

Maybe we should submit them to the official protobuf-parse repo, and then we can switch the official one.

@liuxin231
Copy link
Contributor Author

@PureWhiteWu 了解,我修改后执行测试方法没有问题就给提交了,应该先问一下,我先关闭这个提交。

@liuxin231 liuxin231 closed this Apr 24, 2024
@PureWhiteWu
Copy link
Member

@liuxin231 感谢你的贡献,是我们这边 issue 没有及时更新,后续也没有精力再去提 PR 给上游跟进了。
看起来现在上游重新开始维护了,那我们后续可以把我们的改动先提交一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants