Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): temporarily disable linux aarch64 tests #283

Merged
merged 1 commit into from
Nov 5, 2024

chore(ci): temporarily disable linux aarch64 tests

e509de5
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore(ci): temporarily disable linux aarch64 tests #283

chore(ci): temporarily disable linux aarch64 tests
e509de5
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Nov 5, 2024 in 0s

clippy

31 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 31
Note 0
Help 0

Versions

  • rustc 1.84.0-nightly (fbab78289 2024-11-04)
  • cargo 1.84.0-nightly (031049782 2024-11-01)
  • clippy 0.1.84 (fbab78289d 2024-11-04)

Annotations

Check warning on line 1 in examples/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `pilota::prost::Message as _`

warning: unused import: `pilota::prost::Message as _`
 --> examples/src/lib.rs:1:5
  |
1 | use pilota::prost::Message as _;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 333 in pilota-build/src/middle/context.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> pilota-build/src/middle/context.rs:324:5
    |
324 | /     pub(crate) fn build(
325 | |         self,
326 | |         services: Arc<[crate::IdlService]>,
327 | |         source_type: SourceType,
...   |
332 | |         split: bool,
333 | |     ) -> Context {
    | |________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 595 in pilota-build/src/codegen/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&String` instead of `&str` involves a new object where a slice will do

warning: writing `&String` instead of `&str` involves a new object where a slice will do
   --> pilota-build/src/codegen/mod.rs:595:77
    |
595 |     fn generate_unique_name(existing_names: &AHashSet<String>, simple_name: &String) -> String {
    |                                                                             ^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `#[warn(clippy::ptr_arg)]` on by default
help: change this to
    |
595 ~     fn generate_unique_name(existing_names: &AHashSet<String>, simple_name: &str) -> String {
596 |         let mut counter = 1;
597 ~         let mut name = simple_name.to_owned();
598 |         while existing_names.contains(name.to_ascii_lowercase().as_str()) {
599 |             counter += 1;
600 ~             name = format!("{}_{}", simple_name.to_owned(), counter)
    |

Check warning on line 26 in pilota-build/src/codegen/pkg_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary use of `first().is_some()` to check if slice is not empty

warning: unnecessary use of `first().is_some()` to check if slice is not empty
  --> pilota-build/src/codegen/pkg_tree.rs:26:21
   |
26 |         .filter(|p| p.first().is_some())
   |                     ^^^^^^^^^^^^^^^^^^^ help: replace this with: `!p.is_empty()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_first_then_check

Check warning on line 17 in pilota-build/src/codegen/pkg_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary use of `first().is_some()` to check if slice is not empty

warning: unnecessary use of `first().is_some()` to check if slice is not empty
  --> pilota-build/src/codegen/pkg_tree.rs:17:31
   |
17 |     if pkgs.iter().filter(|p| p.first().is_some()).count() == 0 {
   |                               ^^^^^^^^^^^^^^^^^^^ help: replace this with: `!p.is_empty()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_first_then_check
   = note: `#[warn(clippy::unnecessary_first_then_check)]` on by default

Check warning on line 60 in pilota-build/src/ir/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct `ExceptionVariant` is never constructed

warning: struct `ExceptionVariant` is never constructed
  --> pilota-build/src/ir/mod.rs:60:12
   |
60 | pub struct ExceptionVariant {
   |            ^^^^^^^^^^^^^^^^
   |
   = note: `ExceptionVariant` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

Check warning on line 14 in pilota-build/src/index.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `increment_by` is never used

warning: method `increment_by` is never used
  --> pilota-build/src/index.rs:14:8
   |
3  | pub trait Idx: Sized + Copy + 'static {
   |           --- method in this trait
...
14 |     fn increment_by(&mut self, amount: usize) {
   |        ^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 907 in pilota/src/thrift/binary_unsafe.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> pilota/src/thrift/binary_unsafe.rs:907:6
    |
907 | impl<'a> TInputProtocol for TBinaryUnsafeInputProtocol<'a> {
    |      ^^                                                ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
907 - impl<'a> TInputProtocol for TBinaryUnsafeInputProtocol<'a> {
907 + impl TInputProtocol for TBinaryUnsafeInputProtocol<'_> {
    |

Check warning on line 766 in pilota/src/thrift/binary_unsafe.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> pilota/src/thrift/binary_unsafe.rs:766:6
    |
766 | impl<'a> TLengthProtocol for TBinaryUnsafeInputProtocol<'a> {
    |      ^^                                                 ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
766 - impl<'a> TLengthProtocol for TBinaryUnsafeInputProtocol<'a> {
766 + impl TLengthProtocol for TBinaryUnsafeInputProtocol<'_> {
    |

Check warning on line 67 in pilota/src/prost/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric method

warning: usage of a legacy numeric method
  --> pilota/src/prost/mod.rs:67:24
   |
67 |     if length > usize::max_value() as u64 {
   |                        ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
   |
67 |     if length > usize::MAX as u64 {
   |                        ~~~

Check warning on line 955 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> pilota/src/prost/encoding.rs:955:18
    |
955 |             impl<'a> Drop for DropGuard<'a> {
    |                  ^^                     ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
955 -             impl<'a> Drop for DropGuard<'a> {
955 +             impl Drop for DropGuard<'_> {
    |

Check warning on line 9 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

importing legacy numeric constants

warning: importing legacy numeric constants
 --> pilota/src/prost/encoding.rs:9:55
  |
9 | use core::{cmp::min, convert::TryFrom, mem, str, u32, usize};
  |                                                       ^^^^^
  |
  = help: remove this import
  = note: then `usize::<CONST>` will resolve to the respective associated constant
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants

Check warning on line 9 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

importing legacy numeric constants

warning: importing legacy numeric constants
 --> pilota/src/prost/encoding.rs:9:50
  |
9 | use core::{cmp::min, convert::TryFrom, mem, str, u32, usize};
  |                                                  ^^^
  |
  = help: remove this import
  = note: then `u32::<CONST>` will resolve to the respective associated constant
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants

Check warning on line 4 in pilota/src/prost/message.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

importing legacy numeric constants

warning: importing legacy numeric constants
 --> pilota/src/prost/message.rs:4:24
  |
4 | use core::{fmt::Debug, usize};
  |                        ^^^^^
  |
  = help: remove this import
  = note: then `usize::<CONST>` will resolve to the respective associated constant
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
  = note: `#[warn(clippy::legacy_numeric_constants)]` on by default

Check warning on line 1661 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

value assigned to `skip_default_value` is never read

warning: value assigned to `skip_default_value` is never read
    --> pilota/src/prost/encoding.rs:1661:21
     |
1661 |             let mut skip_default_value = true;
     |                     ^^^^^^^^^^^^^^^^^^
...
1693 |     map!(BTreeMap);
     |     -------------- in this macro invocation
     |
     = help: maybe it is overwritten before being read?
     = note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 1583 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

value assigned to `skip_val` is never read

warning: value assigned to `skip_val` is never read
    --> pilota/src/prost/encoding.rs:1583:25
     |
1583 |                 let mut skip_val = val == val_default;
     |                         ^^^^^^^^
...
1693 |     map!(BTreeMap);
     |     -------------- in this macro invocation
     |
     = help: maybe it is overwritten before being read?
     = note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 1582 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

value assigned to `skip_key` is never read

warning: value assigned to `skip_key` is never read
    --> pilota/src/prost/encoding.rs:1582:25
     |
1582 |                 let mut skip_key = key == &K::default();
     |                         ^^^^^^^^
...
1693 |     map!(BTreeMap);
     |     -------------- in this macro invocation
     |
     = help: maybe it is overwritten before being read?
     = note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 1661 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

value assigned to `skip_default_value` is never read

warning: value assigned to `skip_default_value` is never read
    --> pilota/src/prost/encoding.rs:1661:21
     |
1661 |             let mut skip_default_value = true;
     |                     ^^^^^^^^^^^^^^^^^^
...
1689 |     map!(AHashMap);
     |     -------------- in this macro invocation
     |
     = help: maybe it is overwritten before being read?
     = note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 1583 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

value assigned to `skip_val` is never read

warning: value assigned to `skip_val` is never read
    --> pilota/src/prost/encoding.rs:1583:25
     |
1583 |                 let mut skip_val = val == val_default;
     |                         ^^^^^^^^
...
1689 |     map!(AHashMap);
     |     -------------- in this macro invocation
     |
     = help: maybe it is overwritten before being read?
     = note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 1582 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

value assigned to `skip_key` is never read

warning: value assigned to `skip_key` is never read
    --> pilota/src/prost/encoding.rs:1582:25
     |
1582 |                 let mut skip_key = key == &K::default();
     |                         ^^^^^^^^
...
1689 |     map!(AHashMap);
     |     -------------- in this macro invocation
     |
     = help: maybe it is overwritten before being read?
     = note: `#[warn(unused_assignments)]` on by default
     = note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 49 in pilota-build/src/resolve.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

elided lifetime has a name

warning: elided lifetime has a name
  --> pilota-build/src/resolve.rs:49:47
   |
48 | impl<'a> CollectDef<'a> {
   |      -- lifetime `'a` declared here
49 |     pub fn new(resolver: &'a mut Resolver) -> CollectDef {
   |                                               ^^^^^^^^^^ this elided lifetime gets resolved as `'a`
   |
   = note: `#[warn(elided_named_lifetimes)]` on by default

Check warning on line 246 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:246:11
    |
246 |     #[cfg(feature = "no-recursion-limit")]
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `pb-encode-default-value` and `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 236 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:236:15
    |
236 |     #[cfg(not(feature = "no-recursion-limit"))]
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `pb-encode-default-value` and `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 225 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:225:11
    |
225 |     #[cfg(feature = "no-recursion-limit")]
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `pb-encode-default-value` and `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 217 in pilota/src/prost/encoding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `no-recursion-limit`

warning: unexpected `cfg` condition value: `no-recursion-limit`
   --> pilota/src/prost/encoding.rs:217:15
    |
217 |     #[cfg(not(feature = "no-recursion-limit"))]
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `pb-encode-default-value` and `unstable`
    = help: consider adding `no-recursion-limit` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration