-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Runtime detection, take 2 #86
Open
aumetra
wants to merge
18
commits into
cloudwego:main
Choose a base branch
from
aumetra:runtime-detection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+626
−216
Open
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d165363
Make scalar backends generic over inner SIMD backends
aumetra 00b4538
Make parser generic over SIMD ops
aumetra 3e4afa1
Add runtime dispatch
aumetra f1e458e
Use default types instead
aumetra 1e433f4
Fix warnings and compilation with arbitrary-precision
aumetra 7a4dd0e
Introduce new function on bitmask to allow for generic bitmasks
aumetra c8dc14f
Fix linter warnings
aumetra 7a3a864
Replace explicit bitmask requirement with abstraction
aumetra c6904d6
Fix compile errors
aumetra 0729f54
Merge branch 'main' into runtime-detection
aumetra d153039
Fix compile error
aumetra 7944184
Merge branch 'main' into runtime-detection
aumetra 6180e95
Merge branch 'main' into runtime-detection
aumetra e3fa2cf
Runtime bitmask dispatch for NEON
aumetra cb52681
Fix dispatch, fix macro references
aumetra dab5e68
Cache cpuid result
aumetra 8b73fa9
Merge branch 'main' into runtime-detection
aumetra 76fee9a
Merge branch 'main' into runtime-detection
aumetra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
use std::str::from_utf8_unchecked; | ||
|
||
mod inner; | ||
|
||
cfg_if::cfg_if! { | ||
if #[cfg(feature = "runtime-detection")] { | ||
mod runtime; | ||
pub(crate) use self::runtime::Parser; | ||
} else { | ||
use crate::util::simd::{i8x32, u8x32, u8x64}; | ||
pub(crate) type Parser<R> = self::inner::Parser<R, i8x32, u8x32, u8x64>; | ||
} | ||
} | ||
|
||
pub(crate) use self::inner::ParseStatus; | ||
|
||
pub(crate) const DEFAULT_KEY_BUF_CAPACITY: usize = 128; | ||
pub(crate) fn as_str(data: &[u8]) -> &str { | ||
unsafe { from_utf8_unchecked(data) } | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the runtime detection always has fewer overheads, I think it is better not to enable the feature in the default