fix(volo-build): not add vologen prefix for method arguments type with rust type kind #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Millione
previously approved these changes
Nov 5, 2024
Ggiggle
force-pushed
the
fix/not_use_volo_gen_prefix_for_rust_type
branch
from
e4a6d0e to
2956e5d
Compare
PureWhiteWu
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Referred to #515, when using the rust basic type or predefined types in the volo framework ecosystem as the method arguments, the
vologenprefix would be incorrect to add here.Solution
Only the type defined in idl, which type kind is the
pathkind, will need thisvologenprefix, so we will use this to decide whether to add this prefix.