-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (WIP): use pydantic for model validation #65
Draft
NiceAesth
wants to merge
30
commits into
cloudwithax:main
Choose a base branch
from
NiceAesth:pydantic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiceAesth
changed the title
feat: use pydantic for model validation
feat (WIP): use pydantic for model validation
Feb 23, 2024
for more information, see https://pre-commit.ci
can be used as helpers for type unions
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
allows for more standard handling arguably we shouldn't be using our own exceptions for cases like this in the first place
for more information, see https://pre-commit.ci
not sure about this one
for more information, see https://pre-commit.ci
Looking at the existing code the logic for tracks will become insanely simple by switching to typing based logic |
contains uri and artwork_url for AM and Spotify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: this branch will not function atm
Description
Pydantic is the industry standard tool for model validation. It is a well trusted tool baked into other libraries (such as FastAPI).
This PR aims to shift the library into using it. It will be a very big one, but I will attempt to keep commit history simple. Also, the models will try to keep the same structure as the interfaces used in Lavalink itself.
Reasoning
if
statements for lavalink versionsTo-do:
Models:
Library
Code Style:
type: ignore
commentsdisconnect()
)classmethod
based defaults inTimescale
filters and subclass based defaults withFrequency
filters (e.g.Tremolo
/Vibrato
)Documentation: