Skip to content

Commit

Permalink
cran feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
MarkEdmondson1234 committed Aug 7, 2016
1 parent 913aff4 commit 92ccb7a
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 7 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ Package: googleCloudStorageR
Type: Package
Version: 0.1.0
Title: R Interface with Google Cloud Storage
Description: Interact with Google Cloud Storage API in R. Part of the cloudyR project.
Description: Interact with Google Cloud Storage API in R. Part of the 'cloudyr' project.
Authors@R: c(person("Mark", "Edmondson",email = "[email protected]",
role = c("aut", "cre")))
URL: http://code.markedmondson.me/googleCloudStorageR/
BugReports: https://github.com/cloudyr/googleCloudStorageR/issues
Depends:
R (>= 3.2.0)
Imports:
googleAuthR (>= 0.2.0.9000),
googleAuthR (>= 0.3.1),
testthat(>= 1.0.2),
httr (>= 1.2.1),
jsonlite (>= 1.0)
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# googleCloudStorageR 0.1.0

* Initial release



2 changes: 1 addition & 1 deletion Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ gcs_get_object("your-object", "your-bucket", meta = TRUE)

`googleCloudStorageR` has its own Google project which is used to call the Google Cloud Storage API, but does not have access to the objects or buckets in your Google Project unless you give permission for the library to access your own buckets during the OAuth2 authentication process.

No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets) - this is outlined below:
No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets). The instructions below are for when you visit the Google API console (`https://console.developers.google.com/apis/`)

### For local use

Expand Down
4 changes: 2 additions & 2 deletions vignettes/googleCloudStorageR.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ download_url

## Uploading via a Shiny app

The library is also compatible with Shiny authentication flows, so you can create Shiny apps that lets users log in and download their own data.
The library is also compatible with Shiny authentication flows, so for example you can create Shiny apps that lets users log in and upload their own data.

An example of that is shown below:

Expand Down Expand Up @@ -210,7 +210,7 @@ gcs_get_object("your-object", "your-bucket", meta = TRUE)

`googleCloudStorageR` has its own Google project which is used to call the Google Cloud Storage API, but does not have access to the objects or buckets in your Google Project unless you give permission for the library to access your own buckets during the OAuth2 authentication process.

No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets) - this is outlined below:
No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets). The instructions below are for when you visit the Google API console (`https://console.developers.google.com/apis/`)

### For local use

Expand Down
4 changes: 2 additions & 2 deletions vignettes/googleCloudStorageR.html
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ <h3>Creating download links</h3>
</div>
<div id="uploading-via-a-shiny-app" class="section level2">
<h2>Uploading via a Shiny app</h2>
<p>The library is also compatible with Shiny authentication flows, so you can create Shiny apps that lets users log in and download their own data.</p>
<p>The library is also compatible with Shiny authentication flows, so for example you can create Shiny apps that lets users log in and upload their own data.</p>
<p>An example of that is shown below:</p>
<div class="sourceCode"><pre class="sourceCode r"><code class="sourceCode r"><span class="kw">library</span>(<span class="st">&quot;shiny&quot;</span>)
<span class="kw">library</span>(<span class="st">&quot;googleAuthR&quot;</span>)
Expand Down Expand Up @@ -251,7 +251,7 @@ <h2>Object administration</h2>
<div id="explanation-of-google-project-access" class="section level2">
<h2>Explanation of Google Project access</h2>
<p><code>googleCloudStorageR</code> has its own Google project which is used to call the Google Cloud Storage API, but does not have access to the objects or buckets in your Google Project unless you give permission for the library to access your own buckets during the OAuth2 authentication process.</p>
<p>No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets) - this is outlined below:</p>
<p>No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets). The instructions below are for when you visit the Google API console (<code>https://console.developers.google.com/apis/</code>)</p>
<div id="for-local-use" class="section level3">
<h3>For local use</h3>
<ol style="list-style-type: decimal">
Expand Down

0 comments on commit 92ccb7a

Please sign in to comment.