Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws cli path #8

Closed
wants to merge 11 commits into from
Closed

Update aws cli path #8

wants to merge 11 commits into from

Conversation

ZsoltPath
Copy link

Description

The actual executable in the unzipped package is under aws/dist directory

Motivation and Context

#7

@ZsoltPath ZsoltPath requested a review from bryantbiggs as a code owner July 6, 2020 16:28
@lgtm-com
Copy link

lgtm-com bot commented Jul 6, 2020

This pull request introduces 2 alerts when merging 69c5d83 into ab17048 - view on LGTM.com

new alerts:

  • 2 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2020

This pull request introduces 3 alerts and fixes 1 when merging 942b1ea into ab17048 - view on LGTM.com

new alerts:

  • 3 for Syntax error

fixed alerts:

  • 1 for Unreachable statement

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2020

This pull request introduces 2 alerts when merging 353746d into ab17048 - view on LGTM.com

new alerts:

  • 2 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2020

This pull request introduces 2 alerts when merging 4a026d4 into ab17048 - view on LGTM.com

new alerts:

  • 2 for Syntax error

@bryantbiggs
Copy link
Member

thank you for the PR @ZsoltPath however I don't think this will work. on the normal runners everything appears to be working (see workflows for integration tests), if this fails on a self-hosted runner then I will need to check that out to see whats going on. closing this out for now

@bryantbiggs bryantbiggs closed this Aug 1, 2020
@ZsoltPath
Copy link
Author

@bryantbiggs I am definitely running this on public runners and need that path change.
We're currently using it in half a dozen actions from my forked repo, Otherwise it doesn't work.
I can get you example outputs if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants