Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR Enhancements for Devil May Cry 5 #97

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

mqhaji
Copy link
Contributor

@mqhaji mqhaji commented Dec 25, 2024

Summary

This pull request enhances the HDR processing in Devil May Cry 5 by addressing fundamental flaws in the default tonemapping and color grading methods used in the game. It introduces critical improvements to LUT sampling and gamma to provide a more accurate and immersive HDR experience.

Key Changes Introduced

  • Refined Tonemapping: Implemented a Vanilla+ tonemapper that correctly handles peak white levels, removing the default tonemapping's tendency to overshoot and subsequently clip highlights, which obscured details and degraded the visual quality.
  • Corrected Gamma: Fixed the game's original gamma correction that was likely an attempt at emulating the sRGB -> 2.2 gamma correction. renodx::color::correct::GammaSafe() is now used for proper gamma correction.
  • Enhanced LUT Sampling: Revamped the application of SDR color grading LUTs for HDR output. This includes LUT scaling to adjusts black levels to enhance shadow detail while preserving midtones and highlights. UpgradeToneMap() paired with RenoDRTSmoothClamp() has been used to replace the game's original tonemapping and inverse tonemapping method to apply SDR LUTs to HDR, thus correcting broken looking highlight colors and better preserving the original artistic intent.

Conclusion

This mod significantly refines the HDR capabilities of Devil May Cry 5, correcting several key issues with the original game's HDR implementation. By adjusting how LUTs are applied and fixing the gamma correction, this mod not only enhances the visual fidelity of the game but also ensures that the HDR presentation is true to the creators' vision.

- lut scaling
- srgb -> 2.2 emulation
- upgradetonemap() with RenoDRTSmoothClamp() for lut sampling
- DICE tonemapping
@mqhaji mqhaji changed the title feat(dmc5): add support for dmc5 HDR Enhancements for Devil May Cry 5 Dec 25, 2024
@clshortfuse clshortfuse merged commit 7d90ded into clshortfuse:main Dec 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants