Fix bug in lemma2synset mapping #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8 mentioned that some words return +8000 words when querying for synonyms. This is because some lemmata return
Noneas a value when queried for their synset. These words are then mapped toNonein thelemma2synsetdictionary, which causes the inverse dictionarysynset2lemmato return a whole bunch of garbage lemmata when queryingNone.This PR fixes that issue by checking whether the
synset_idof a lemma isNonebefore creating a mapping. The mapping dictionaries are also changed fromdefaultdicttodict, as this can still causeNonethings to be added to the mapping dictionary.