Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create user 'sdc' with specified UID #14

Open
wants to merge 5 commits into
base: streamsets
Choose a base branch
from
Open

Create user 'sdc' with specified UID #14

wants to merge 5 commits into from

Conversation

jarcec
Copy link
Contributor

@jarcec jarcec commented Jan 20, 2018

No description provided.

dimaspivak
dimaspivak reviewed Jan 20, 2018
View reviewed changes
Copy link
Member

@dimaspivak dimaspivak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you ever foresee a need to change this number? If not, I’d just define it as a constant to stop from cluttering the cli with too many args that aren’t ever used.

@jarcec
Copy link
Contributor Author

jarcec commented Jan 20, 2018

Honestly, I do not and my first iteration had the number hardcoded. I just felt that Mr. @dimaspivak would of course want to have it as an argument :D

@dimaspivak dimaspivak force-pushed the streamsets branch 3 times, most recently from f1c7378 to 4f545be Compare February 16, 2018 17:26
@dimaspivak dimaspivak force-pushed the streamsets branch 2 times, most recently from 59158bf to ccf2b08 Compare May 8, 2018 21:00
@kirtiv1 kirtiv1 force-pushed the streamsets branch 2 times, most recently from 2ebaeda to dd87a3f Compare May 18, 2018 21:19
@kirtiv1 kirtiv1 force-pushed the streamsets branch 4 times, most recently from b9dfbd6 to f58120e Compare June 22, 2018 23:45
@kirtiv1 kirtiv1 force-pushed the streamsets branch 2 times, most recently from 82077e6 to cb979f5 Compare June 11, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaspivak dimaspivak dimaspivak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarcec @dimaspivak