enable tagliatelle linter

Signed-off-by: Etai Lev Ran <[email protected]>

.golangci.yaml

@@ -60,7 +60,7 @@ linters:
     - revive
     - staticcheck
     - stylecheck
-    # - tagliatelle
+    - tagliatelle
     - tenv
     - testableexamples
     # - thelper

cmd/gwctl/config/config.go

@@ -33,15 +33,15 @@ const (
 
 // ClientConfig contain all Client configuration to send requests to the GW.
 type ClientConfig struct {
-	GwIP             string        `json:"gwIP"`
-	GwPort           uint16        `json:"gwPort"`
-	ID               string        `json:"ID"`
-	CaFile           string        `json:"CaFile"`
-	CertFile         string        `json:"CertFile"`
-	KeyFile          string        `json:"KeyFile"`
-	Dataplane        string        `json:"Dataplane"`
-	PolicyEngineIP   string        `json:"PolicyEngineIP"`
-	MetricsManagerIP string        `json:"MetricsManagerIP"`
+	GwIP             string        `json:"gw_ip"`
+	GwPort           uint16        `json:"gw_port"`
+	ID               string        `json:"id"`
+	CaFile           string        `json:"ca_file"`
+	CertFile         string        `json:"cert_file"`
+	KeyFile          string        `json:"key_file"`
+	Dataplane        string        `json:"dataplane"`
+	PolicyEngineIP   string        `json:"policy_engine_ip"`
+	MetricsManagerIP string        `json:"metrics_manager_ip"`
 	logger           *logrus.Entry `json:"-"`
 }
 

pkg/policyengine/PolicyDispatcher_test.go

@@ -241,6 +241,7 @@ func TestDisableEnablePeers(t *testing.T) {
 	require.Equal(t, peer1, connReqResp.TargetPeer) // peer1 was re-enabled, so it is now chosen again
 }
 
+//nolint:unparam // `svc` always receives `svcName` (allow passing other names in future)
 func addRemoteSvc(t *testing.T, svc, peer string, ph policyengine.PolicyDecider) {
 	ph.AddPeer(peer) // just in case it was not already added
 	action, err := ph.AddBinding(&api.Binding{Spec: api.BindingSpec{Import: svc, Peer: peer}})

pkg/policyengine/k8sshim/connectivity_policy_crd.go

@@ -50,10 +50,11 @@ type ConnectivityPolicy struct {
 
 // ConnectivityPolicySpec is a common spec for both PrivilegedConnectivityPolicy and ConnectivityPolicy.
 type ConnectivityPolicySpec struct {
-	Action          policytypes.PolicyAction
-	From            policytypes.WorkloadSetOrSelectorList `json:"from"`
-	To              policytypes.WorkloadSetOrSelectorList `json:"to"`
-	ConnectionAttrs []ConnectionAttrs                     `json:"connectionAttrs,omitempty"`
+	Action policytypes.PolicyAction
+	From   policytypes.WorkloadSetOrSelectorList `json:"from"`
+	To     policytypes.WorkloadSetOrSelectorList `json:"to"`
+	//nolint:tagliatelle // use camelCase, same as k8s convention
+	ConnectionAttrs []ConnectionAttrs `json:"connectionAttrs,omitempty"`
 }
 
 // ConnectionAttrs describes the combination of protocol and port used by a given connection.

pkg/policyengine/policytypes/connectivity_policy.go

@@ -55,7 +55,9 @@ type WorkloadSetOrSelectorList []WorkloadSetOrSelector
 // WorkloadSetOrSelector describes a set of workloads, based on their attributes (labels)
 // Exactly one of the two fields should be non-empty.
 type WorkloadSetOrSelector struct {
-	WorkloadSets     []string              `json:"workloadSets,omitempty"`
+	//nolint:tagliatelle // use camelCase, same as k8s convention
+	WorkloadSets []string `json:"workloadSets,omitempty"`
+	//nolint:tagliatelle // use camelCase, same as k8s convention
 	WorkloadSelector *metav1.LabelSelector `json:"workloadSelector,omitempty"`
 }