Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MBG (partially) from code #168

Merged
merged 32 commits into from
Nov 9, 2023
Merged

Remove MBG (partially) from code #168

merged 32 commits into from
Nov 9, 2023

Conversation

michalmalka
Copy link
Collaborator

Still need to remove from Demos...

michalmalka and others added 9 commits November 6, 2023 14:52
@michalmalka
Remove MBG from code...
c059941 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
Update events.go
cfd51de 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
Merge branch 'remove_mbg' of github.com:michalmalka/clusterlink into …
3f32021 
…remove_mbg
@michalmalka
Merge branch 'remove_mbg' of github.com:michalmalka/clusterlink into …
48931f5 
…remove_mbg

Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
Merge branch 'remove_mbg' of github.com:michalmalka/clusterlink into …
136468a 
…remove_mbg
@michalmalka
Update events.go
02879bd 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
Merge branch 'clusterlink-net:main' into remove_mbg
5f84592
@michalmalka
Merge branch 'clusterlink-net:main' into remove_mbg
6f2e6af 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
Merge branch 'remove_mbg' of github.com:michalmalka/clusterlink into …
f3b0cd2 
…remove_mbg
@kfirtoledo kfirtoledo requested a review from zivnevo November 7, 2023 14:35
@kfirtoledo
Copy link
Collaborator

kfirtoledo commented Nov 7, 2023 •
edited
Loading

LGTM, but most of the changes were done in the policy-engine(@zivnevo)

kfirtoledo and others added 2 commits November 7, 2023 17:33
@kfirtoledo
cmd/cl-adm: Add log-level flag (clusterlink-net#167)
3c8ccdb 
Add log-level flag to control the level of log messages.

Signed-off-by: Kfir Toledo <[email protected]>
@elevran
Add -v / --version to executables (clusterlink-net#171)
a25b2cd 
* Build `gwctl` from directory path, not file
* Add version info package
  - populates source control variables from runtime/debug.BuildInfo
  - adds a global version.txt file (should be updated on every formal release)
  - Short() to allow setting cobra.Command.Version string
* Add `Version` to each root Cobra command (this automatically enables `-v` and `--version` flags)

Signed-off-by: Etai Lev Ran <[email protected]>
elevran
elevran requested changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why are the config/manifests files removed?
  • How was the list of changes created?
    1. grep -ri mbg . | grep -v -e demo -e Binary -e git | wc -l seems to return more instances than this PR changes
    2. There's an occurrence in the README (Multi-Border Gateway).

@michalmalka
Copy link
Collaborator Author

@elevran For your comments

  • the manifests yaml folder is not used anymore from my understanding (@orozery ?)
  • all other instances will be removed by Kfir (Demo folder)
  • In README - last instance in readme I didn't remove yet as wanted to remove it only after we will remove all instances... (After Kfir's PR)
    I'll go over it again and will see if we can remove it already.

@elevran
Copy link
Collaborator

elevran commented Nov 8, 2023

the manifests yaml folder is not used anymore from my understanding (@orozery ?)

please open a separate PR for that, if possible. Seems unrelated.

I'll go over it again and will see if we can remove it already.

thanks!

elevran
elevran approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible, remove the config/manifests in a separate PR.

@michalmalka
bring back manifests
1002150 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
remove MBG
78dae84 
Signed-off-by: MICHAL MALKA <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 8, 2023
zivnevo
zivnevo approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@zivnevo zivnevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

orozery and others added 5 commits November 8, 2023 16:51
@orozery
bootstrap/platform/k8s: Switch CA on gwctl pod
d65c30d 
This commit switches the gwctl pod to use the peer CA instead of the fabric CA.
This ensures that gwctl will not be able to connect to other peers.

Signed-off-by: Or Ozeri <[email protected]>
@orozery
tests/k8s.sh: Change logs output directory
2bb50b0 
This commit changes the logs output directory of the k8s.sh test.

Signed-off-by: Or Ozeri <[email protected]>
@michalmalka
Remove MBG from code...
3180ef8
@michalmalka
Update events.go
287053a 
Signed-off-by: MICHAL MALKA <[email protected]>
@dependabot @elevran @michalmalka
build(deps): bump the cli group with 1 update (clusterlink-net#165)
de2ec1a 
Bumps the cli group with 1 update: [github.com/spf13/cobra](https://github.com/spf13/cobra).

- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: cli
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Etai Lev Ran <[email protected]>
dependabot bot and others added 13 commits November 9, 2023 10:25
@dependabot @michalmalka
build(deps): bump github.com/bombsimon/logrusr/v4 from 4.0.0 to 4.1.0 (…
20ccbb7 
…clusterlink-net#166)

Bumps [github.com/bombsimon/logrusr/v4](https://github.com/bombsimon/logrusr) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/bombsimon/logrusr/releases)
- [Commits](bombsimon/logrusr@v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: github.com/bombsimon/logrusr/v4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@michalmalka
bring back manifests
e5043a4 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
remove MBG
27f68c2 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
Merge branch 'remove_mbg' of github.com:michalmalka/clusterlink into …
3b116d6 
…remove_mbg
@michalmalka
Remove MBG from code...
181ebe5 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
Update events.go
9354b4b 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
Remove MBG from code...
5e7b418
@michalmalka
Update events.go
cd6c854 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
bring back manifests
eac1d97 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
remove MBG
ff2fe6f 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
Remove MBG from code...
3164cf5
@michalmalka
bring back manifests
1739967 
Signed-off-by: MICHAL MALKA <[email protected]>
@michalmalka
Merge branch 'remove_mbg' of github.com:michalmalka/clusterlink into …
28e9565 
…remove_mbg
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 9, 2023
@michalmalka michalmalka merged commit c6cf9ea into clusterlink-net:main Nov 9, 2023
@michalmalka michalmalka linked an issue Nov 13, 2023 that may be closed by this pull request
Remove MBG acronyms from the code #12
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elevran elevran elevran approved these changes

@zivnevo zivnevo zivnevo approved these changes

@kfirtoledo kfirtoledo Awaiting requested review from kfirtoledo kfirtoledo is a code owner

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove MBG acronyms from the code
5 participants
@michalmalka @kfirtoledo @elevran @zivnevo @orozery