docs: Installation Guide for ClusterLink #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create Installation Guide for ClusterLink in local and remote environemnt. Signed-off-by: Kfir Toledo <[email protected]>
orozery
requested changes
Nov 13, 2023
elevran
requested changes
Nov 14, 2023
kfirtoledo
force-pushed
the
readme
branch
2 times, most recently
from
b6d9f0e to
f5e02e3
Compare
Signed-off-by: Kfir Toledo <[email protected]>
Signed-off-by: Kfir Toledo <[email protected]>
praveingk
requested changes
Nov 15, 2023
docs/installation.md
Outdated
|
|
||
| ## 2. Expose the ClusterLink deployment to a public IP | ||
| Create a public IP for accessing the ClusterLink gateway. | ||
| For a local environment (e.g., Kind), create a K8s nodeport service: |
There was a problem hiding this comment.
Is the step the same for a local k8s cluster? Why not say local K8S cluster instead of KIND, since KIND is not a deployment env.
There was a problem hiding this comment.
Check now, (feel free to suggest another option)
Signed-off-by: Kfir Toledo <[email protected]>
|
@orozery, @elevran , @praveingk PTAL |
orozery
requested changes
Nov 16, 2023
Signed-off-by: Kfir Toledo <[email protected]>
praveingk
approved these changes
Nov 17, 2023
elevran
approved these changes
Nov 19, 2023
|
@orozery PTAL |
orozery
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Installation Guide for ClusterLink in local and remote environemnt.
Signed-off-by: Kfir Toledo [email protected]