New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make `testpackage` linter pass #252

Merged

elevran merged 2 commits into clusterlink-net:main from elevran:testpackage_linter

Jan 7, 2024

Collaborator

elevran commented Jan 5, 2024

enable linter in configuration
move tests to their own package
change tests to only inspect external behavior (e.g., no labels returned for deleted Pod, not that arrays are empty)


          make testpackage linter pass

da79d58

Signed-off-by: Etai Lev Ran <[email protected]>

elevran requested a review from kfirtoledo

January 5, 2024 12:08

pull-request-size bot added the size/M label

kfirtoledo approved these changes

View reviewed changes


          Merge branch 'main' into testpackage_linter

6b6221e

Signed-off-by: Etai Lev Ran <[email protected]>

elevran merged commit 510ca51 into clusterlink-net:main

9 checks passed

elevran deleted the testpackage_linter branch

January 7, 2024 07:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels