controlplane/control: Introduce peer manager #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orozery
force-pushed
the
peer-manager
branch
3 times, most recently
from
6565b83 to
b41c772
Compare
kfirtoledo
reviewed
Mar 4, 2024
| meta.SetStatusCondition(&m.pr.Status.Conditions, reachableCond) | ||
| m.lock.Unlock() | ||
|
|
||
| m.statusCallback(m.pr) |
There was a problem hiding this comment.
Can you add a comment why you call the callback
There was a problem hiding this comment.
Sure (it's for non-CRD mode, which does not watch Peer status).
| } | ||
|
|
||
| // Start the peer manager. | ||
| func (m *peerManager) Start() error { |
There was a problem hiding this comment.
Where do you call this function?
There was a problem hiding this comment.
It's called by the runnable manager, which subscribes here:
clusterlink/cmd/cl-controlplane/app/server.go
Line 205 in b41c772
kfirtoledo
approved these changes
Mar 5, 2024
This commit adds the peerManager which is responsible for monitoring peers, and updating peer status (reachable or not). Signed-off-by: Or Ozeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the peerManager which is responsible for monitoring peers, and updating peer status (reachable or not).