-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Go-based dataplane for xDS control plane APIs #58
Conversation
Co-authored-by: Or Ozeri <[email protected]>
Co-authored-by: Or Ozeri <[email protected]>
Co-authored-by: Or Ozeri <[email protected]>
@praveingk Can you add an e2e test for this? |
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
I have added dataplane type in cl-adm, and edited docker script. Please check c63110c and 7ac823f and feel free to edit it accordingly. |
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also change the github actions workflow to run tests/k8s.sh
with the go dataplane?
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
Done in 48f9ac1 |
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@praveingk Can you also add a switch case check to PeerOptions::Run()
to verify that DataplaneType
has a valid value?
Signed-off-by: Pravein-Govindan-Kannan <[email protected]>
Its done here : 0faaeb2 |
@orozery reading through the conversation it seems all requests have been addressed. Is there anything else that needs to be done? If not - please mark approval so it can be merged |
Re-creating based on #44
@elevran : Addressed most of the comments from the previous PR, except the dataplane API refactoring (using controller) suggested by @orozery which would be done as another PR after removing the old dataplane code.